Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mprovement] Add request QR for Read Only accounts with warning #287

Closed
WietseWind opened this issue Nov 14, 2020 · 1 comment
Closed

[mprovement] Add request QR for Read Only accounts with warning #287

WietseWind opened this issue Nov 14, 2020 · 1 comment
Assignees
Labels
App iOS/Android App

Comments

@WietseWind
Copy link
Member

We removed the QR with wallet address for Read Only accounts because too many users added their Exchange deposit address as read only account (despite the warning) then to show the QR and deposit from another app... Without a destination tag.

People request the return of feature. I propose we:

  • Re-add the button (Request / Show QR) for Read Only accounts, just like for unactivated accounts
  • If pressed on a Read Only account: ALWAYS show a warning first:
Do you own the keys to this Read Only account, or is this your exchange account?

[ I own the keys ] | [ Exchange Account ]

If people press "I own the keys" we show the QR panel.

If people press "Exchange account", we show an alert:

You cannot deposit directly to your exchange account: you need a destination tag to do so. Please get your destination tag from your exchange, and deposit manually.
@WietseWind WietseWind added the App iOS/Android App label Nov 14, 2020
@WietseWind WietseWind added this to Next sprint (0.7.0) in XUMM 0.X, 1.X & 2.1 Nov 14, 2020
@canny
Copy link

canny bot commented Nov 14, 2020

This issue has been linked to a Canny post: Re-Add QR Code Requests for Read-only accounts 🎉

@WietseWind WietseWind moved this from Next sprint (0.7.0) to 0.6.1 (Todo) in XUMM 0.X, 1.X & 2.1 Nov 16, 2020
@N3TC4T N3TC4T moved this from 1.0.0 🎉 to Done, test (1.0.0) in XUMM 0.X, 1.X & 2.1 Dec 16, 2020
@WietseWind WietseWind moved this from Done, test (1.0.0) to Tested, ready for release in XUMM 0.X, 1.X & 2.1 Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App iOS/Android App
Projects
XUMM 0.X, 1.X & 2.1
  
Released (V1 🎉) (1.0.1)
Development

No branches or pull requests

3 participants