Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types change: Payload(s) [POST/GET]: signers (null | string[]) #29

Closed
2 tasks done
WietseWind opened this issue Apr 12, 2022 · 2 comments
Closed
2 tasks done

Types change: Payload(s) [POST/GET]: signers (null | string[]) #29

WietseWind opened this issue Apr 12, 2022 · 2 comments

Comments

@WietseWind
Copy link
Member

WietseWind commented Apr 12, 2022

TL;DR:

Payloads have a new meta property: signers. The field can be null or an array containing between one and an arbitrary amount (currently hard capped by our backend at four, client doesn't have to enforce) XRPL account addresses.

When one or more account addresses are entered, XUMM forces signing with one of those accounts.

Impact:

  • Payload GET types (meta.signers) (null or string[])
  • Paylost POST types (options.signers) (omit, null or string[])

Commit to XUMM-SDK:

XRPL-Labs/XUMM-SDK@8b5c484

Based on discussion:

XRPL-Labs/Xaman-Issue-Tracker#384 (comment)

@dangell7
Copy link
Collaborator

GET: cc4e5b7
POST: dbe040f

@WietseWind
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants