We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clio returns invalidParams whereas rippled returns objectNotFound with malformed base_asset values in get_aggregate_price
invalidParams
objectNotFound
123
-1
0
1.2
Request:
{ "method": "get_aggregate_price", "params": [ { "base_asset": 123, "quote_asset": "ETH", "oracles": [ { "account": "rwz8i5bUKa12tYxQjsSuzDQaBwKkuGUqa5", "oracle_document_id": 1 }, { "account": "rDtBhKmzKveCSd5jmrcQD6CU8kidCLCy7h", "oracle_document_id": 1 } ] } ] }
Rippled response:
{ "result": { "error": "objectNotFound", "error_code": 92, "error_message": "The requested object was not found.", "ledger_current_index": 82290, "request": { "base_asset": 123, "command": "get_aggregate_price", "oracles": [ { "account": "rwz8i5bUKa12tYxQjsSuzDQaBwKkuGUqa5", "oracle_document_id": 1 }, { "account": "rDtBhKmzKveCSd5jmrcQD6CU8kidCLCy7h", "oracle_document_id": 1 } ], "quote_asset": "ETH" }, "status": "error", "validated": false } }
Clio response:
{ "result": { "error": "invalidParams", "error_code": 31, "error_message": "Invalid parameters.", "status": "error", "type": "response", "request": { "method": "get_aggregate_price", "params": [ { "base_asset": 123, "quote_asset": "ETH", "oracles": [ { "account": "rwz8i5bUKa12tYxQjsSuzDQaBwKkuGUqa5", "oracle_document_id": 1 }, { "account": "rDtBhKmzKveCSd5jmrcQD6CU8kidCLCy7h", "oracle_document_id": 1 } ] } ] } }, "warnings": [ { "id": 2001, "message": "This is a clio server. clio only serves validated data. If you want to talk to rippled, include 'ledger_index':'current' in your request" } ] }
The text was updated successfully, but these errors were encountered:
I think Clio's response (invalidParams) maybe more descriptive.
Sorry, something went wrong.
Issue is fixed on rippled end for the below invalid test data.
None, "Invalid", 123, -1, 0, 1.2, "H", "HB", "HBAR", "", _INVALID_NON_STANDARD_CURRENCY_CODE_:"0158415500000000C1F76FF6ECB0BAC600000000A"
objectNotFound remains same for the below cases
VALID_NON_STANDARD_CURRENCY_CODE = "0158415500000000C1F76FF6ECB0BAC600000000", "HBA"
Clio is not replicating invalidParams error for below test data
"Invalid", _INVALID_NON_STANDARD_CURRENCY_CODE_:"0158415500000000C1F76FF6ECB0BAC600000000A", "H", "HB", "HBAR", ""
No branches or pull requests
Issue Description
Clio returns
invalidParams
whereas rippled returnsobjectNotFound
with malformed base_asset values in get_aggregate_priceSteps to Reproduce
123
,-1
,0
,1.2
Request:
Expected Result
Rippled response:
Actual Result
Clio response:
Environment
Supporting Files
The text was updated successfully, but these errors were encountered: