Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async framework refactor stopToken #1380

Open
godexsoft opened this issue Apr 26, 2024 · 0 comments
Open

Async framework refactor stopToken #1380

godexsoft opened this issue Apr 26, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@godexsoft
Copy link
Collaborator

Summary

Stop token is separate from cancellation flag atm.
Let's see if it makes sense to combine the two under one token/context struct.

Motivation

Currently there are two parameters on scheduled operation callback - stopToken and bool. In most cases user doesn't need to know the reason of stopping.

Solution

We could simplify it to one parameter stopToken. Also in case user still need to get a reason of stopping we should add method reason() returning enum value Canceled or Stopped.

@godexsoft godexsoft added the enhancement New feature or request label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant