Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-monitor validation performance #3508

Open
carlhua opened this issue Jul 9, 2020 · 2 comments
Open

Self-monitor validation performance #3508

carlhua opened this issue Jul 9, 2020 · 2 comments
Assignees
Labels
Feature Request Used to indicate requests to add new features Metrics RIPD Export Exported from legacy JIRA issue tracking

Comments

@carlhua
Copy link
Contributor

carlhua commented Jul 9, 2020

If rippled is configured as a validator, it should monitor its own performance. Currently, we do log cases where build one ledger and later accept a different one as fully validated. But it would really be nice to have statistics on validation performance.

Specifically, we should track:

  1. The fraction / indexes of ledgers we are not sending validations for
  2. The fraction / indexes of ledgers we send validations for, but they don't match the ledger hash we later accept as fully valid
  3. The fraction / indexes of ledgers we send validations for and which are subsequently accepted as fully valid (happy path)

We can, and should, track this for non validators too. Instead of being based on validations sent, it can be based on ledgers built as a result of consensus rounds.

Exported from RIPD-1287

@carlhua carlhua added Feature Request Used to indicate requests to add new features RIPD Export Exported from legacy JIRA issue tracking labels Jul 9, 2020
@intelliot intelliot added this to the 2024 release milestone Sep 21, 2023
@intelliot
Copy link
Collaborator

Writing this info to a log file seems best, but we don't want to create another log. We should be able to estimate the file's rate of growth. Could offer sample scripts for how to view/aggregate the data.

May be something for @thejohnfreeman / @Bronek to look into.

@Bronek
Copy link
Collaborator

Bronek commented Jan 18, 2024

I am starting to think that writing this to the existing perflog would be a decent solution:

  • the data gets persisted between restarts etc.
  • we get to use the existing perflog infrastructure
  • perflog would still have to be filtered e.g. by Grafana scripts to find the relevant info, but I guess it already is anyway

At the same time, we could also add some of this information to get_counts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Used to indicate requests to add new features Metrics RIPD Export Exported from legacy JIRA issue tracking
Projects
Status: 📋 Backlog
Development

No branches or pull requests

4 participants