Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set OwnerPaysFee to obsolete #4582

Open
intelliot opened this issue Jun 23, 2023 · 0 comments
Open

Set OwnerPaysFee to obsolete #4582

intelliot opened this issue Jun 23, 2023 · 0 comments
Labels
Good First Issue Great issue for a new contributor Will Need Documentation

Comments

@intelliot
Copy link
Collaborator

intelliot commented Jun 23, 2023 •
edited

OwnerPaysFee can be marked as obsolete.

REGISTER_FEATURE(OwnerPaysFee,                  Supported::no,  DefaultVote::no);
  • OwnerPaysFee is not supported so can't be voted on anyway.

Originally posted by @RichardAH in #4282 (comment)

While the amendment is expected to work and has been implemented and tested, no one has really wanted it after 7 years. It is not listed on explorers like XRPSCAN, and it was introduced in c549c9d. FlowCross uses the functionality to do offer crossing through the payment engine, but no one seems to want the amendment, so we are fine with calling it obsolete.
@intelliot intelliot added Good First Issue Great issue for a new contributor Will Need Documentation labels Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Great issue for a new contributor Will Need Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@intelliot