Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PriceOracle: get_aggregate_price method input field issues #4961

Open
SaxenaKaustubh opened this issue Mar 21, 2024 · 0 comments
Open

PriceOracle: get_aggregate_price method input field issues #4961

SaxenaKaustubh opened this issue Mar 21, 2024 · 0 comments

Comments

@SaxenaKaustubh
Copy link
Collaborator

While calculating PriceOracle aggregate pricing using the get_aggregate_price method, I noticed the following issues:

  1. trim: A decimal value e.g. 1.2 gets truncated to int e.g.1.
  2. oracle_document_id: A decimal value e.g. 1.2 gets truncated to int e.g.1.
  3. There is no input validation on the oracle_document_id field for an input of None.
  4. There is no input validation on BaseAsset and QuoteAsset fields. All of the following values are acceptable:
    • None
    • "Invalid"
    • 123
    • -1
    • 0
    • 1.2
    • "0158415500000000C1F76FF6ECB0BAC600000000A"
    • "H"
    • "HB"
    • "HBAR"
    • ""
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant