Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise test coverage of AMM to 100% #5000

Open
thejohnfreeman opened this issue Apr 23, 2024 · 0 comments
Open

Raise test coverage of AMM to 100% #5000

thejohnfreeman opened this issue Apr 23, 2024 · 0 comments
Assignees
Labels
Feature Request Used to indicate requests to add new features

Comments

@thejohnfreeman
Copy link
Collaborator

This change requires a discussion of whether and how to meet the goal before it is implemented. Here is a list of the top 30 files, under src/ripple/, added and changed by the AMM PR #4294, in order of increasing added lines:

src/ripple/app/tx/impl/Offer.h
src/ripple/app/tx/impl/AMMVote.h
src/ripple/app/tx/impl/AMMCreate.h
src/ripple/app/paths/impl/StrandFlow.h
src/ripple/protocol/jss.h
src/ripple/app/tx/impl/AMMBid.h
src/ripple/protocol/impl/Issue.cpp
src/ripple/app/misc/AMMUtils.h
src/ripple/protocol/QualityFunction.h
src/ripple/protocol/impl/STIssue.cpp
src/ripple/app/paths/AMMContext.h
src/ripple/protocol/impl/AMMCore.cpp
src/ripple/protocol/AMMCore.h
src/ripple/protocol/STIssue.h
src/ripple/app/paths/impl/AMMOffer.cpp
src/ripple/app/paths/AMMLiquidity.h
src/ripple/app/paths/AMMOffer.h
src/ripple/app/misc/impl/AMMUtils.cpp
src/ripple/app/misc/impl/AMMHelpers.cpp
src/ripple/rpc/handlers/AMMInfo.cpp
src/ripple/app/paths/impl/AMMLiquidity.cpp
src/ripple/app/paths/impl/BookStep.cpp
src/ripple/app/tx/impl/AMMDeposit.h
src/ripple/app/tx/impl/AMMWithdraw.h
src/ripple/app/tx/impl/AMMVote.cpp
src/ripple/app/misc/AMMHelpers.h
src/ripple/app/tx/impl/AMMBid.cpp
src/ripple/app/tx/impl/AMMCreate.cpp
src/ripple/app/tx/impl/AMMWithdraw.cpp
src/ripple/app/tx/impl/AMMDeposit.cpp

Please take a look at their uncovered lines in the latest report. One easy way is to search for filenames in the search box under the right edge of the graph. Point out any lines that should be considered unreachable by an effective test. We can mark them excluded from coverage in a future PR.

@thejohnfreeman thejohnfreeman added the Feature Request Used to indicate requests to add new features label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Used to indicate requests to add new features
Projects
None yet
Development

No branches or pull requests

3 participants