Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conan Requirement is (>=1.60.0 <2 || >=2.0.5) | Rippled 2.1.0 #4926

Open
enriquemanuel opened this issue Feb 22, 2024 · 1 comment · May be fixed by #5001
Open

Conan Requirement is (>=1.60.0 <2 || >=2.0.5) | Rippled 2.1.0 #4926

enriquemanuel opened this issue Feb 22, 2024 · 1 comment · May be fixed by #5001

Comments

@enriquemanuel
Copy link

enriquemanuel commented Feb 22, 2024

Issue Description

The instructions to build Rippled state that it should need 1.55, but using 1.56 wont work, and the new GRPC binary requires a higher Conan.
Docs in the build need changing for the conan version

Steps to Reproduce

  1. docker run -it -v $HOME/Downloads:/mnt thejohnfreeman/rippled-build-ubuntu:12e19cd9034b
  2. git clone -b 2.1.0 --progress https://github.com/XRPLF/rippled
  3. cd rippled
  4. mkdir .build && cd .build
  5. conan profile new default --detect
  6. conan profile update settings.compiler.cppstd=20 default
  7. conan install .. --output-folder . --build missing --settings build_type=Release
    Failure:
1.631 grpc/1.50.1: Downloaded recipe revision 0
1.647 ERROR: grpc/1.50.1: Cannot load recipe.
1.647 Error loading conanfile at '/root/.conan/data/grpc/1.50.1/_/_/export/conanfile.py': Current Conan version (1.56.0) does not satisfy the defined one (>=1.60.0 <2 || >=2.0.5).
------
Dockerfile:124

Expected Result

Actual ripple would build a release

Actual Result

Got an error due to a depenency from a conanfile that requires 1.60 or higher

Environment

Ubuntu 22, Dockerized

Thanks

Thanks to @thejohnfreeman for his amazing container! second time using it and it works flawlessly. I actually downloaded the repo and changed the version of conan to 1.60 conan_version=${CONAN_VERSION:-1.63} and it worked without any issues. Conan 2.1.0 doesn't work.

@thejohnfreeman
Copy link
Collaborator

I don't think any Conan 2.x will work. We should change the documentation to state the Conan requirement is >=1.60 <2.

thejohnfreeman added a commit to thejohnfreeman/rippled that referenced this issue Apr 23, 2024
@thejohnfreeman thejohnfreeman linked a pull request Apr 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants