Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove models for signing using a rippled server #223

Open
mDuo13 opened this issue Mar 31, 2021 · 1 comment
Open

Remove models for signing using a rippled server #223

mDuo13 opened this issue Mar 31, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@mDuo13
Copy link
Collaborator

mDuo13 commented Mar 31, 2021

The request models to sign a transaction using a rippled server are unnecessary and can be used unsafely. To reduce confusion, we should remove them. The rippled sign method is admin-only by default and deprecated anyway.

The following should be removed:

Furthermore, the model xrpl.models.requests.Submit should be an alias for xrpl.models.requests.SubmitOnly.
@mDuo13 mDuo13 added the enhancement New feature or request label Mar 31, 2021
@mDuo13 mDuo13 mentioned this issue Mar 31, 2021
Open
@mvadari
Copy link
Collaborator

mvadari commented Nov 17, 2021

Should these be deprecated first or just removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mDuo13 @mvadari