Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SubscribeBook should be accessible directly from xrpl.models #394

Closed
LimpidCrypto opened this issue May 31, 2022 · 1 comment · Fixed by #395
Closed

SubscribeBook should be accessible directly from xrpl.models #394

LimpidCrypto opened this issue May 31, 2022 · 1 comment · Fixed by #395

Comments

@LimpidCrypto
Copy link
Contributor

LimpidCrypto commented May 31, 2022 •
edited

The xrpl/models/__init__.py imports all requests models (line 19). But the xrpl/models/requests/__init__.py does not import SubscribeBook (line 40). The SubscribeBook object is in the file xrpl/models/requests/subscribe.py. It should be directly importable from xrpl.models. This should be a pretty easy change.
@LimpidCrypto LimpidCrypto changed the title SubscribeBook should be accessible directly from xrpl.models SubscribeBook should be accessible directly from xrpl.models May 31, 2022
@khancode khancode mentioned this issue May 31, 2022
Merged
7 tasks
@khancode
Copy link
Collaborator

@LimpidCrypto here's the fix - #395

@mvadari mvadari linked a pull request Jun 1, 2022 that will close this issue
export SubscribeBook request model #395
Merged
7 tasks
@mvadari mvadari closed this as completed Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

export SubscribeBook request model XRPLF/xrpl-py
3 participants
@mvadari @khancode @LimpidCrypto