Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional marker to get_account_transactions #426

Closed
LimpidCrypto opened this issue Aug 19, 2022 · 1 comment · Fixed by #427
Closed

Add optional marker to get_account_transactions #426

LimpidCrypto opened this issue Aug 19, 2022 · 1 comment · Fixed by #427

Comments

@LimpidCrypto
Copy link
Contributor

The high-level method get_account_transactions should have an argument marker.
When requesting account_tx it is not guaranteed to receive all transactions an account has ever sent at once.
When an account has a transaction history that is too large, the node only sends a part of it, up to an amount it would become inefficient. If that's the case it also sends a marker field to indicate at what Ledger the node has stopped. The user can use it for the next call to tell the node where to start, to receive the next batch of transactions.

For get_account_transactions that argument is missing but would be very useful IMO.
If added to get_account_transactions, the function get_account_payment_transactions should also get that argument.

@JST5000
Copy link
Collaborator

JST5000 commented Sep 14, 2022

Closing this as "won't fix" because it's better to just directly use the AccountTx request instead of building a helper which does the exact same thing without processing. In a version 2, we should probably remove the get_account_transactions sugar function since it doesn't add much to the raw request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants