Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

一个小小BUG，路由匹配规则时会区分大小写 #192

Closed
CatSamaDD opened this issue Jan 20, 2021 · 3 comments · Fixed by #195
Closed

一个小小BUG，路由匹配规则时会区分大小写 #192

CatSamaDD opened this issue Jan 20, 2021 · 3 comments · Fixed by #195
Labels
enhancement New feature or request

Comments

@CatSamaDD
Copy link

域名下的路径是区分大小写的，但是域名是不区分大小写的。
Xray匹配路由规则时会把域名区分大小写。
打个比方，我设置abc123.com 走 dircert
然后访问 ABC123.COM 的时候就不会匹配这个规则
但其实他们是同一个域名。
一般浏览器会把域名大写字母自动转成小写，但是有些软件是不会的，比如我之前反应FTPS连接问题时用的FileZilla。
QQ截图20210120205101
@RPRX
Copy link
Member

RPRX commented Jan 20, 2021

匹配前应当 strings.ToLower

@RPRX RPRX added the enhancement New feature or request label Jan 20, 2021
@badO1a5A90 badO1a5A90 mentioned this issue Jan 21, 2021
Merged
@RPRX RPRX closed this as completed in #195 Jan 21, 2021
@RPRX
Copy link
Member

RPRX commented Jan 21, 2021

5aa053a

@RPRX
Copy link
Member

RPRX commented Jan 22, 2021

https://github.com/XTLS/Xray-core/releases/tag/v1.2.3

@darsvador darsvador mentioned this issue Mar 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

convert domain names to lowercase when matching badO1a5A90/Xray-core
2 participants
@CatSamaDD @RPRX