Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Xcode 9.3 #108

Closed
dan-zheng opened this issue Jan 28, 2018 · 23 comments
Closed

Add support for Xcode 9.3 #108

dan-zheng opened this issue Jan 28, 2018 · 23 comments

Comments

@dan-zheng
Copy link

I tried installing XVim2 for the new Xcode 9.3 beta but couldn't get it to work.

I followed these steps:

  • Codesign Xcode 9.3 beta and xcode-select -s /Applications/Xcode-beta.app/
  • Clone XVim2 and run make
  • Open Xcode and accept "Load Bundle", relaunch Xcode

I tried adding the new Xcode 9.3 UUID (8CC8AD71-C38D-4C1A-A34B-DC78BCE76F57) to XVim2/Info.plist to no avail.
I tried re-codesigning Xcode, uninstalling and reinstalling XVim2, also to no avail.

Am I missing something? Did anyone else get it to work?

@mayqiyue
Copy link

+1

3 similar comments
@BOOLRon
Copy link

BOOLRon commented Feb 7, 2018

+1

@Granfalloner
Copy link

+1

@Mmmmabury
Copy link

+1

@ivmos
Copy link

ivmos commented Mar 12, 2018

Confirmed it simply does not work with 9.3 yet?

@yixiang
Copy link

yixiang commented Mar 13, 2018

Confirmed that XVim2 doesn't work in Xcode 9.3 beta 4.

Console log:

2018-03-13 15:37:09.127909-0700 Xcode[83477:1997568] Calling IOPPFGetProperty thermally_optimized_xcode!
2018-03-13 15:37:10.065038-0700 Xcode[83477:1997652] Calling IOPPFGetProperty simulator_utility_clamp!
2018-03-13 15:37:10.522986-0700 Xcode[83477:1997568] MessageTracer: Falling back to default whitelist
2018-03-13 15:37:10.524980-0700 Xcode[83477:1997659] NSURLConnection finished with error - code -1100
2018-03-13 15:37:11.523676-0700 Xcode[83477:1997568] Unknown class GPUTesselationSliderCell in Interface Builder file.
2018-03-13 15:37:12.242903-0700 GPUToolsAgent[83485:1997767] Mac Agent inited !!!
2018-03-13 15:37:42.516175-0700 Xcode[83477:1997568] [MT] DVTAssertions: Warning in /Library/Caches/com.apple.xbs/Sources/IDEFrameworks/IDEFrameworks-14136.3/IDEKit/Extension/SourceEditor/IDESourceEditorExtension.m:114
Details:  Built-in source editor extension 'com.apple.dt.XcodeBuiltInExtensions' was not located within 30 seconds.
Object:   <IDESourceEditorExtension>
Method:   +_verifyBuiltInSourceEditorExtensionsFound
Thread:   <NSThread: 0x10da002f0>{number = 1, name = main}
Please file a bug at http://bugreport.apple.com with this warning message and any useful information you can provide.
2018-03-13 15:37:42.516282-0700 Xcode[83477:1997568] [MT] DVTAssertions: Warning in /Library/Caches/com.apple.xbs/Sources/IDEFrameworks/IDEFrameworks-14136.3/IDEKit/Extension/SourceEditor/IDESourceEditorExtension.m:118
Details:  Built-in source editor extension 'com.apple.dt.XCDocumenter.XCDocumenterExtension' was not located within 30 seconds.
Object:   <IDESourceEditorExtension>
Method:   +_verifyBuiltInSourceEditorExtensionsFound
Thread:   <NSThread: 0x10da002f0>{number = 1, name = main}
Please file a bug at http://bugreport.apple.com with this warning message and any useful information you can provide.

@pebble8888
Copy link
Member

pebble8888 commented Mar 21, 2018

An major cause is that Xcode9.3 beta4 has empty IDEPegasusSourceEditor.ideplugin which XVim use.

$ du -sh /Applications/Xcode.app/Contents/PlugIns/IDEPegasusSourceEditor.ideplugin/
 28K	IDEPegasusSourceEditor.ideplugin/

We need to modify something.

@hyouuu
Copy link

hyouuu commented Mar 29, 2018

Release is out (and apparently not working) - any observations?

@yixiang
Copy link

yixiang commented Mar 29, 2018

Filed a Radar bug report against Apple, but they closed it a few days later citing plugins are no longer supported. So that path is a dead end.

@pitoneux
Copy link

well I just filed another one... https://bugreport.apple.com/web/?problemID=39015122

@keith
Copy link

keith commented Mar 29, 2018

It looks like some internal classes got moved around here. Here's the new hierarchy of the source editor:

IDESourceEditor.IDESourceEditorView
   | DVTSourceEditor.DVTPegasusSourceEditorView
   |    | SourceEditor.SourceEditorView
   |    |    | NSView
   |    |    |    | NSResponder
   |    |    |    |    | NSObject```

@pebble8888
Copy link
Member

pebble8888 commented Mar 31, 2018

It looks like we need more swift method calling wrapper (about 5~10 method and property) for Xcode9.3 support.
For example,

$ xcrun swift-demangle __T012SourceEditor0aB4ViewC9firstRectSC6CGRectVSC8_NSRangeV17forCharacterRange_SpyAHGSg06actualJ0tF
_T012SourceEditor0aB4ViewC9firstRectSC6CGRectVSC8_NSRangeV17forCharacterRange_SpyAHGSg06actualJ0tF ---> SourceEditor.SourceEditorView.firstRect(forCharacterRange: __C._NSRange, actualRange: Swift.UnsafeMutablePointer<__C._NSRange>?) -> __C.CGRect
$ xcrun swift-demangle  __T012SourceEditor0aB11ContentViewC37accessibilityInsertionPointLineNumberSiyF
_T012SourceEditor0aB11ContentViewC37accessibilityInsertionPointLineNumberSiyF ---> SourceEditor.SourceEditorContentView.accessibilityInsertionPointLineNumber() -> Swift.Int

@sarah
Copy link

sarah commented Mar 31, 2018

Just here to add a +1 to seeing this issue.

@eclectocrat
Copy link

+1

@pebble8888
Copy link
Member

Xcode9.3 is almost supported in branch develop or tag xcode9.3.
Use branch master or tag xcode9.2 for Xcode9.2.

Some feature is not supported.
You can check to grep XCODE93 for the entire source.

For drive force to develop,
https://www.bountysource.com/teams/xvim

@hyouuu
Copy link

hyouuu commented Apr 1, 2018

Thanks for making progress @pebble8888 !! However when make got these errors:

Ld build/Release/XVim2.xcplugin/Contents/MacOS/XVim2 normal x86_64 cd /Users/shawngong/Downloads/XVim2-develop export MACOSX_DEPLOYMENT_TARGET=10.13 /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -arch x86_64 -bundle -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk -L/Users/shawngong/Downloads/XVim2-develop/build/Release -L/Users/shawngong/Downloads/XVim2-develop -F/Users/shawngong/Downloads/XVim2-develop/build/Release -filelist /Users/shawngong/Downloads/XVim2-develop/build/XVim2.build/Release/XVim2.build/Objects-normal/x86_64/XVim2.LinkFileList -Xlinker -rpath -Xlinker @executable_path/../Frameworks -Xlinker -rpath -Xlinker @loader_path/../Frameworks -mmacosx-version-min=10.13 -Xlinker -object_path_lto -Xlinker /Users/shawngong/Downloads/XVim2-develop/build/XVim2.build/Release/XVim2.build/Objects-normal/x86_64/XVim2_lto.o -fobjc-arc -fobjc-link-runtime -L/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/macosx -Xlinker -add_ast_path -Xlinker /Users/shawngong/Downloads/XVim2-develop/build/XVim2.build/Release/XVim2.build/Objects-normal/x86_64/XVim2.swiftmodule -Wl,-no_compact_unwind /Users/shawngong/Applications/Xcode.app/Contents/SharedFrameworks/DVTKit.framework/Versions/A/DVTKit /Users/shawngong/Applications/Xcode.app/Contents/Frameworks/IDEKit.framework/Versions/A/IDEKit /Users/shawngong/Applications/Xcode.app/Contents/SharedFrameworks/DVTFoundation.framework/Versions/A/DVTFoundation /Users/shawngong/Applications/Xcode.app/Contents/Frameworks/IDEFoundation.framework/Versions/A/IDEFoundation -Xlinker -dependency_info -Xlinker /Users/shawngong/Downloads/XVim2-develop/build/XVim2.build/Release/XVim2.build/Objects-normal/x86_64/XVim2_dependency_info.dat -o /Users/shawngong/Downloads/XVim2-develop/build/Release/XVim2.xcplugin/Contents/MacOS/XVim2 clang: error: no such file or directory: '/Users/shawngong/Applications/Xcode.app/Contents/SharedFrameworks/DVTKit.framework/Versions/A/DVTKit' clang: error: no such file or directory: '/Users/shawngong/Applications/Xcode.app/Contents/Frameworks/IDEKit.framework/Versions/A/IDEKit' clang: error: no such file or directory: '/Users/shawngong/Applications/Xcode.app/Contents/SharedFrameworks/DVTFoundation.framework/Versions/A/DVTFoundation' clang: error: no such file or directory: '/Users/shawngong/Applications/Xcode.app/Contents/Frameworks/IDEFoundation.framework/Versions/A/IDEFoundation'

@pebble8888
Copy link
Member

@hyouuu
Fixed. Please check it.

@hyouuu
Copy link

hyouuu commented Apr 1, 2018

Confirmed develop works - thanks so much @pebble8888 !

@hyouuu
Copy link

hyouuu commented Apr 1, 2018

I would vote for search functionality to be fixed first :D

@darkamenosa
Copy link

darkamenosa commented Apr 7, 2018

@hyouuu

Confirmed develop works - thanks so much @pebble8888 !

How did you do that? I switched to develop branch and rebuilt it. It didn't work for me

@darkamenosa
Copy link

I created new certificate and signed again. After that, switched branch to develop. And followed installation step again. It worked!

Thanks guys!

@hieonn
Copy link

hieonn commented Apr 11, 2018

Just like other guys' comments, changing the branch into development and make uninstall and make again. then you would be able to have working version on Xcode 9.3. I have big respect for the contributors and huge thanks. Thanks again. - expect escaping from Apple's Tyranny

@pebble8888
Copy link
Member

Now, master branch is for Xcode9.3.

@pebble8888 pebble8888 changed the title Add support for Xcode 9.3 beta Add support for Xcode 9.3 Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests