Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate creating "tamper" sensors for each sensor #98

Open
XaF opened this issue Feb 22, 2023 · 1 comment
Open

Evaluate creating "tamper" sensors for each sensor #98

XaF opened this issue Feb 22, 2023 · 1 comment

Comments

@XaF
Copy link
Owner

XaF commented Feb 22, 2023

Pros:

  • Clear sensor identifying if another sensor is currently tampered
  • Possible to disable by default a sensor, but keep its tamper enabled by default (e.g. for sensors that do not update a state, but do support tamper)

Cons:

  • A lot more sensors showing in Home Assistant, more noisy
  • Huge internal refactor as a single QolsysSensor object might lead to more than one sensor sent to MQTT
  • Breaking change (we could probably keep, but deprecate, the tamper attribute for a few versions)
@jsb5151
Copy link

jsb5151 commented Jul 28, 2023

IMHO, I don't think this is feasible due to #117 - multiple loop sensors will most likely always create phantom Tampered conditions when another sensor is triggered on the same device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants