Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double Jslib Path in JavascriptURI #20

Closed
sinza opened this issue Jun 10, 2012 · 4 comments
Closed

double Jslib Path in JavascriptURI #20

sinza opened this issue Jun 10, 2012 · 4 comments

Comments

@sinza
Copy link

sinza commented Jun 10, 2012

xajax 6.0-beta1 creates a double xajax Jslib Path in the script tags
example:
w/o config.javascriptURI
src="xajax_js/xajax_js/xajax_core.js" charset="UTF-8"
src="xajax_js/xajax_js/xajax_debug.js" charset="UTF-8"

with config.javascriptURI ("fileadmin/plugins/xajax/")
src="/fileadmin/plugins/xajax/xajax_js/xajax_js/xajax_core.js" charset="UTF-8"
src="/fileadmin/plugins/xajax/xajax_js/xajax_js/xajax_debug.js" charset="UTF-8"

uncommenting line 430 fixes this issue
xajaxPluginManager.inc.php Line 430

  • $sJsURI .= 'xajax_js/';
  • #$sJsURI .= 'xajax_js/';
@romacron
Copy link
Contributor

Hello Sinza,

you are able to fix the line in your branch and make an pull-request

@sinza
Copy link
Author

sinza commented Jun 11, 2012

Moin romacron,

i am new to Git so let`s cross fingers that the change and pull request i made fit our needs ^^

@romacron
Copy link
Contributor

hey sinza,

everything is correctly filled. Now you have to press the Pull-Request Button.
That tell the Project Root Member (Xajax) that you have made an change which should be merged into the Xajax-Main Project.

The Project Root Member executes the merge (if he has time)
you are also able to use your changes by yourself.

@nichdiekuh
Copy link
Collaborator

fixed via #29, thanks to @holtkamp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants