Update plugin for ProjectQ v0.5.1 support, including IBM API v2 #62
Conversation
| ### Contributors | ||
|
|
||
| This release contains contributions from (in alphabetical order): | ||
|
|
||
| Maria Schuld | ||
|
|
There was a problem hiding this comment.
Need to add yourself @josh146 :)
There was a problem hiding this comment.
😆 Oddly enough, the tests now pass for me locally, but not on travis...
There was a problem hiding this comment.
Is it possible that Travis' token expired?
| @@ -1,2 +1,3 @@ | |||
| projectq | |||
| git+https://github.com/ProjectQ-Framework/ProjectQ.git#egg=projectq | |||
There was a problem hiding this comment.
This will always use the latest commit to master, no? What if there is a future long-lived commit in master that is broken? Would it be better to pick a particular release/commit?
There was a problem hiding this comment.
Unfortunately the ProjectQ IBM API fix was only committed 5 days ago. This change is so that we can work on this PR and verify we can get the plugin working with the IBM backend; we should re-evaluate the status of ProjectQ before merging this in.
But good call on pinning to a particular commit 👍
There was a problem hiding this comment.
It looks like this is going to be released soon as v0.5.1
There was a problem hiding this comment.
josh146
changed the title
josh146
changed the title
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
==========================================
- Coverage 98.26% 96.15% -2.11%
==========================================
Files 6 6
Lines 230 234 +4
==========================================
- Hits 226 225 -1
- Misses 4 9 +5
Continue to review full report at Codecov.
|
|
Solved in PR #65. |
Description of the Change:
Updates signature of IBM device.
Related GitHub Issues:
Fixes #61