Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] svg preview #17

Open
CrackHub opened this issue Aug 28, 2020 · 13 comments
Open

[Request] svg preview #17

CrackHub opened this issue Aug 28, 2020 · 13 comments
Assignees

Comments

@CrackHub
Copy link

Can you support svg files? I don't wanna install any other app for this. Thanks.

@Xanashi Xanashi self-assigned this Sep 5, 2020
@Xanashi
Copy link
Owner

Xanashi commented Sep 5, 2020

SVG support is something I personally would love to see in Icaros as well, as I work with SVG files every day.
However FFmpeg requires the third party library librsvg, which in addition requires several other libraries, to render SVG files.

I'm trying to avoid having too many libraries in Icaros, to keep it as lightweight as possible, so I'm currently considering other
possibilities for adding SVG support.

Bottomline is, it's on my todo list!

@ElizTriad
Copy link

@Destroy666x
Copy link

If you don't want to bundle additional libraries, perhaps allow users to link to their ffmpeg, e.g. I'm using ffmpeg-full on all Windows installs. Assuming the version required by and bundled with Icaros isn't too outdated.

@Xanashi
Copy link
Owner

Xanashi commented Jun 22, 2023

I mentioned this in another github issue, so I'm going to take my reply from there:
Loading FFmpeg dynamically is a very daunting task, with lots of potential complications including security/malware, debugging, instability and so on. It's just not viable.

The version of FFmpeg included in Icaros is very up-to-date, it just doesn't include too many additional libraries.
With all that said I am working on SVG support right now, so stay tuned!

@Destroy666x
Copy link

Daunting - maybe, depends on how the app is coded.

Security/malware risks - I don't think so, if implemented any properly. Bunch of popular apps written in various languages allow that. To name a few: ShareX, Krita, Audacity.

@Xanashi
Copy link
Owner

Xanashi commented Jun 22, 2023

Icaros is loaded automatically by Explorer every time a file requires a thumbnail for any filetype supported by Icaros.
Say someone distributed Icaros with a version of FFmpeg that they've modded with malicious code, any user that installed
their distribution would very like trigger this malicious code right away, the second they enabled thumbnailing.
All with my frontend and app brand.

@Destroy666x
Copy link

I see your point but not sure I agree with that. E.g. they could also bundle Icaros installer + some virus install right now, if they really want to. It's not as "easy" perhaps, but it happens regularly with e.g. pirated software distributed through torrents. Whether it's really well disguised or just "Open that other .exe to crack the software" or in this case "Open that other (clearly a plugin) .exe to gain extra benefits, such as .svg preview".

@neoOpus
Copy link

neoOpus commented Aug 30, 2023

It is better to use MS PowerToys for this

image

@fossist
Copy link

fossist commented Dec 7, 2023

It is better to use MS PowerToys for this

PowerToys is a very huge package just for SVG. Most tools in PowerToys are useless and can be replaced by 3rd party tools which are better and not cpu heavy.

Inclusion of SVG in icaros will be a huge update.

@Xanashi
Copy link
Owner

Xanashi commented Dec 7, 2023

I'm working on it right now, I just don't have an ETA for when it will be ready. 👍

@yw4z
Copy link

yw4z commented Mar 3, 2024

is there any progress on this. thanks for your efforts

@Xanashi
Copy link
Owner

Xanashi commented Mar 10, 2024

I'm currently a bit overwhelmed by work and other IRL things, but SVG is still the top priority for me to get included,
besides bug fixes. So I am actively working on it whenever I have the time.

@yw4z
Copy link

yw4z commented Mar 10, 2024

not in hurry. just wondered status. thanks for your all efforts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants