Removed viewBox attributes #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These seem to create issues when scaling documents. See: https://bugs.launchpad.net/inkscape/+bug/1796713.
|
Interesting, Inkscape can provide the SVG using viewBox (instead of width and height) I guess to keep the icons size independent of the unit. 🤔 Seems to me more an Inkscape bug than an expected behaviour. A change in the document properties should adapt the symbols to its new size, intead of just movimg them ramdomly around the screen. Not 100% sure but your bug in Inkscape should be reviewed again. Thanks, I'll tests this out ang merge if it works as expected. |
|
Yes, I also think that it is an inkscape bug. But since I do not know when it will be resolved in went with the workaround for now :)
…On Wed, Oct 17, 2018, at 08:15, Xaviju wrote:
Interesting, Inkscape can provide the SVG using viewBox (instead of
width and height) I guess to keep the icons size independent of the
unit. 🤔
Seems to me more an Inkscape bug than an expected behaviour. A change in
the document properties should adapt the symbols to its new size, intead
of just movimg them ramdomly around the screen. Not 100% sure but your
bug in Inkscape should be reviewed again.
Thanks, I'll tests this out ang merge if it works as expected.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#100 (comment)
|
|
Tested. The bug is correct and the merge fixes this bug. I think I'll revert this once the inkscape bug is fixed because Thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These seem to create issues when scaling documents. See:
https://bugs.launchpad.net/inkscape/+bug/1796713.