Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race Condition crash with obs_shutdown in Source Mirror #22

Closed
Xaymar opened this issue Nov 7, 2018 · 0 comments
Closed

Race Condition crash with obs_shutdown in Source Mirror #22

Xaymar opened this issue Nov 7, 2018 · 0 comments
Labels
bug Bugs such as crashing, freezing, broken functionality, etc.
Milestone
Source Mirror (Co...

Comments

@Xaymar
Copy link
Owner

Xaymar commented Nov 7, 2018

Describe the bug
A rare crash may be observed if there is audio data and obs_shutdown is running at the same time.

To Reproduce

  1. Add a Source Mirror
  2. Set it to mirror an audio source and enable audio.
  3. Exit obs.
  4. Occasionally this will crash.

Expected behavior
OBS will correctly exit.

Desktop (please complete the following information):

  • Operating System: Windows 10
  • Kernel Version: 1809 Build 17763.55
  • Plugin Version: master

Additional context
The crash happens because aud and aoi are not checked for nullptr and instead just used.
@Xaymar Xaymar closed this as completed in 16f55ca Nov 7, 2018
@Xaymar Xaymar added bug Bugs such as crashing, freezing, broken functionality, etc. status:fixed labels Nov 7, 2018
Repository owner locked as resolved and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Bugs such as crashing, freezing, broken functionality, etc.
Projects
None yet
Milestone
Source Mirror (Component, Source)
Development

No branches or pull requests
1 participant
@Xaymar