Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Blur filter on Mac, only Box and Dual Filtering works #576

Closed
mwdiers opened this issue Jun 9, 2021 · 5 comments
Closed

In Blur filter on Mac, only Box and Dual Filtering works #576

mwdiers opened this issue Jun 9, 2021 · 5 comments
Labels
bug Bugs such as crashing, freezing, broken functionality, etc. can't-fix Issues that can't or won't be fixed. good-report Issue report has everything necessary to figure out the feature/bug/crash and is a good reference.

Comments

@mwdiers
Copy link

mwdiers commented Jun 9, 2021

Operating System

MacOS 10.15 and higher

OBS Studio Version?

27.0 (including Release Candidates)

StreamFX Version

0.11.0a1

Expected Behavior

Change Blur type to Box Linear, Gaussian, or Gaussian Linear. Change size or sub-type. See effect change.

Current Behavior

On macOS 11.4, x64, the only Blur effect that works is the Box and Dual Filtering types. Choosing Gaussian or Gaussian Linear has no effect. Changing controls in either of those modes has no effect. Choosing Box Linear causes a black screen.

Occasionally, choosing Gaussian leaves the Box blur in place. Controls have no effect until Type is changed back to Box.

Steps to Reproduce the Bug

Add blur filter to any scene object, whether video, image, or camera.
Set blur type to anything other than Box.

OBS Studio Log

https://obsproject.com/logs/3cbMsaGhJGJX0eho

OBS Studio Crash Log

No response

Any additional Information we need to know?

This is a standard package install of OBS 27 and StreamFX 0.11a1. This problem has existed in all official macOS releases of StreamFX.

@mwdiers mwdiers added status:help-wanted bug Bugs such as crashing, freezing, broken functionality, etc. labels Jun 9, 2021
@mwdiers mwdiers changed the title [BUG] Only Box and Dual Filtering blur works on Mac [BUG] In Blur filter on Mac, only Box and Dual Filtering works Jun 9, 2021
@mwdiers
Copy link
Author

mwdiers commented Jun 9, 2021

Looking at the log, this appears to be an OpenGL issue.

@Xaymar
Copy link
Owner

Xaymar commented Jun 10, 2021

This is indeed an OpenGL issue, though I have no idea why. The error log does not present useful information here, so I'll be left debugging something that I can't actually see or know.

@Xaymar
Copy link
Owner

Xaymar commented Jun 10, 2021

Confirmed.
I've fixed all code that just threw multiple types together implicitly to do so explicitly, which makes Shaders compile fine on OpenGL on Windows, however it does not fix the entire issue. A part of this issue exists upstream in OBS Studio, but can be worked around - although at a hefty performance cost.

@Xaymar
Copy link
Owner

Xaymar commented Jun 11, 2021

Fix submitted upstream: obsproject/obs-studio#4864

In the mean time, I will add an alternative blur type based on kernel textures instead of kernel arrays. This runs worse than arrays would, however it supports a theoretically infinite size of blur - as long as your GPU doesn't die from the number of samples required.

@Xaymar Xaymar added the good-report Issue report has everything necessary to figure out the feature/bug/crash and is a good reference. label Jun 11, 2021
@Xaymar Xaymar changed the title [BUG] In Blur filter on Mac, only Box and Dual Filtering works In Blur filter on Mac, only Box and Dual Filtering works Jun 15, 2021
@Xaymar Xaymar added this to the 0.11 milestone Jun 16, 2021
@Xaymar
Copy link
Owner

Xaymar commented Aug 26, 2021

This appears to be a bug upstream in OBS Studio!
The bug or problem you reported appears to originate from OBS Studio. Unfortunately, due to past disagreements with the OBS Project team about how the project is run, I have been asked to no longer submit bugs or fixes to OBS Studio or any of its direct projects. I will abide by this agreement, until it is lifted or other means force me to no longer abide by this agreement.

@Xaymar Xaymar closed this as completed Aug 26, 2021
@Xaymar Xaymar added the can't-fix Issues that can't or won't be fixed. label Aug 26, 2021
@Xaymar Xaymar added this to the Blur (Component, Filter) milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs such as crashing, freezing, broken functionality, etc. can't-fix Issues that can't or won't be fixed. good-report Issue report has everything necessary to figure out the feature/bug/crash and is a good reference.
Projects
None yet
Development

No branches or pull requests

2 participants