Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper HTTP response codes for errors #4

Closed
jasonclemons opened this issue Jul 3, 2013 · 1 comment
Closed

Proper HTTP response codes for errors #4

jasonclemons opened this issue Jul 3, 2013 · 1 comment
Assignees
Milestone

Comments

@jasonclemons
Copy link
Member

The responses for errors feel a bit mixed up, for example https://www.xboxleaders.com/api/2.0/games.json?gamertag=Major%20N!elson will return an error telling us the user doesn't exist with a 200 response code. It feels like it should be a 404 with the same message. Likewise for achievements and games. In cases where there is a problem like an invalid value perhaps a 400. The messages themselves are good but using HTTP responses consistently would be better for the end-user.

-- Sent via email

@djekl
Copy link
Contributor

djekl commented Jul 4, 2013

This is now achieved via the pull request above.

To change the output code given change it in the list of error codes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants