Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default value not working for queries #3

Closed
javierbrea opened this issue Jun 14, 2019 · 2 comments · Fixed by #13
Closed

Default value not working for queries #3

javierbrea opened this issue Jun 14, 2019 · 2 comments · Fixed by #13
Assignees
@javierbrea
Labels
bug Something isn't working
Projects
Mercury browser storage
Milestone
v1.2.0

Comments

@javierbrea
Copy link
Member

The bug described in the xbyorange/mercury-memory library related to the default value of queried sources is applicable to this library too.

It is desirable to apply the same fix here.
@javierbrea javierbrea added the bug Something isn't working label Jun 14, 2019
@javierbrea javierbrea added this to To do in Mercury browser storage via automation Jun 14, 2019
@javierbrea javierbrea mentioned this issue Jun 14, 2019
Closed
@javierbrea
Copy link
Member Author

Same bug than described in XbyOrange/mercury-memory#3
Dependent of XbyOrange/mercury#5

@javierbrea javierbrea added this to the v1.2.0 milestone Oct 16, 2019
@javierbrea javierbrea self-assigned this Oct 16, 2019
@javierbrea javierbrea moved this from To do to In progress in Mercury browser storage Oct 16, 2019
@javierbrea javierbrea moved this from In progress to Ready for release in Mercury browser storage Oct 16, 2019
@javierbrea
Copy link
Member Author

In order to avoid breaking changes, this new behavior should be activated using a new option called "queriesDefaultValue". A warning will be traced if this option is not received until next major version, in which the option will be deprecated and the described behavior will be the default one.

@javierbrea javierbrea mentioned this issue Oct 16, 2019
Merged
Mercury browser storage automation moved this from Ready for release to Done Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javierbrea javierbrea

Labels
bug Something isn't working
Projects
Mercury browser storage
  
Done
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

V1.2.0 XbyOrange/mercury-browser-storage
1 participant
@javierbrea