Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update testing #325

Closed
mcm1957 opened this issue Oct 26, 2023 · 3 comments
Closed

Please update testing #325

mcm1957 opened this issue Oct 26, 2023 · 3 comments

Comments

@mcm1957
Copy link

mcm1957 commented Oct 26, 2023

Please update standard testing (#217). PR is older than a year in the meantime.

Please include node 20 into tests as node 20 is already released as stable verion unless this adapter fails using node 20. In this case please create a issue and try to fix ist as soon as possible.

Please add engine>16 into package.json when updateing adapter core to 3.x.x as adapter core 3.x.x fails at node 14 and earlier.

@Xenon-s
Copy link
Owner

Xenon-s commented Oct 26, 2023

Thanks the for the issue as a reminder.
I had to update the adapter quickly because the adapter was no longer compatible with the new JS controller. As more and more issues, forum posts and facebook questions came in, I pushed the current version to stable
I had cleared this with Apollon. The bugs will be fixed in the next few days 😉

@mcm1957
Copy link
Author

mcm1957 commented Oct 26, 2023

No problem - I wrote ... for the next release ...
It completly ok to provide a hoitfix for js-controller now without minimum delay. THANKS a lot.

@Xenon-s
Copy link
Owner

Xenon-s commented Oct 29, 2023

fixed in 3.0.1

@Xenon-s Xenon-s closed this as completed Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants