Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vivaldi support #1

Closed
Crayder opened this issue Jan 28, 2024 · 4 comments
Closed

Vivaldi support #1

Crayder opened this issue Jan 28, 2024 · 4 comments

Comments

@Crayder
Copy link

Crayder commented Jan 28, 2024

I'm currently trying to use the Chrome driver to launch a Vivaldi session. I've done this before in the past, but it seems Vivaldi changed it's versioning:

image

This version of Vivaldi should be using the 120 version of the Chrome driver. But the Vivaldi version seems to be throwing off the version check. Is there a way around this?

@Xeo786
Copy link
Owner

Xeo786 commented Jan 29, 2024

With new session pass Viviladi Exe Path

Browser := New Rufaydium()
instance := Browser.NewSession(ViviladiExePath)

@Crayder
Copy link
Author

Crayder commented Jan 29, 2024

I've tried that already. Same error with or without unfortunately.
Latest version of everything, still happens:

image


This is my entire script for testing, as an example:

#SingleInstance, Force
#Persistent
#NoEnv
SendMode Input
SetWorkingDir, %A_ScriptDir%
SetWinDelay, 0
OnExit("EndSessions")

#Include ../Rufaydium/Rufaydium.ahk

browserPath := "C:\Users\ciles\Desktop\Vivald\Application\vivaldi.exe"
browserDriver := "chromedriver.exe"

Browser := new Rufaydium(browserDriver)
Browser.capabilities.Setbinary(browserPath)

; Set `--new-window` argument so that each new session will have it's own window. 
Browser.capabilities.addArg("--new-window")
Browser.capabilities.addArg("--profile-directory=Default")
Browser.capabilities.addArg("--app=https://www.youtube.com")

; "C:\Users\ciles\Desktop\Vivald\Application\vivaldi.exe" --new-window --profile-directory=Default --app=https://www.youtube.com
BrowserSession := browser.NewSession(browserPath)

return

EndSessions() {
    global Browser
    Browser.QuitAllSessions()
    Browser.Driver.Exit()
    ExitApp, 
    return
}

@Xeo786
Copy link
Owner

Xeo786 commented Jan 30, 2024

While creating Browser Session Rufaydium check for Browser version with viviladi version which does not matches,
I haven't put support for Viviladi, but all the methods would work fine, you just need to modify Rufaydium class to skip version check for viviladi

@Crayder
Copy link
Author

Crayder commented Jan 31, 2024

Fair answer to me, I'll take a look!

@Crayder Crayder closed this as completed Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants