Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speedy: fix failed to enlarge g11 radio #76

Merged
merged 1 commit into from Jun 25, 2020
Merged

speedy: fix failed to enlarge g11 radio #76

merged 1 commit into from Jun 25, 2020

Conversation

hamishzx
Copy link
Collaborator

Fixes #70

@hamishzx hamishzx added the Bug label Jun 25, 2020
Xi-Plus
Xi-Plus approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@Xi-Plus Xi-Plus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

個人覺得只有按鈕放大，文字沒有放大怪怪的。

@Xi-Plus
Copy link
Member

Xi-Plus commented Jun 25, 2020

文字放大為1.5倍差不多好看。

		if (criterion.value === 'g11' && Twinkle.getPref('enlargeG11Input')) {
			criterion.style = 'font-size: 1.5em; line-height: 1.5em;';
		}

@hamishzx
Copy link
Collaborator Author

個人覺得只有按鈕放大，文字沒有放大怪怪的。

先把这个bug修了再另开一个pr调整是不是比较好？

@Xi-Plus
Copy link
Member

Xi-Plus commented Jun 25, 2020 •
edited

先把这个bug修了再另开一个pr调整是不是比较好？

可

@hamishzx hamishzx mentioned this pull request Jun 25, 2020
Closed
@hamishzx hamishzx merged commit 9c94098 into master Jun 25, 2020
@hamishzx hamishzx deleted the FIX-enlarge-g11-radio branch June 25, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xi-Plus Xi-Plus Xi-Plus approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

G11為2倍大失效
2 participants
@hamishzx @Xi-Plus