*:support capacity unit read/write statistics #318

zhangyifan27 · 2019-04-15T03:00:44Z

Ref issue #235

src/shell/command_helper.h

src/server/info_collector.cpp

src/server/info_collector.h

src/server/info_collector.cpp

src/shell/command_helper.h

src/server/info_collector.cpp

src/server/info_collector.h

src/server/pegasus_server_impl.cpp

scripts/falcon_screen.json

src/server/pegasus_write_service_impl.h

src/server/pegasus_server_impl.cpp

src/server/pegasus_write_service_impl.h

src/server/info_collector.cpp

src/server/pegasus_server_impl.cpp

acelyc111 · 2019-04-18T12:19:11Z

已解决的comment点一下"Resolve conversation"吧便于查看还有哪些没resolve的

src/server/pegasus_server_impl.h

src/server/config-server.ini

src/server/info_collector.cpp

src/server/capacity_unit_calculator.h

src/server/pegasus_server_impl.h

src/server/capacity_unit_calculator.h

src/server/capacity_unit_calculator.cpp

src/server/capacity_unit_calculator.h

src/server/pegasus_write_service_impl.h

src/server/available_detector.cpp

src/server/available_detector.h

src/server/capacity_unit_calculator.cpp

src/server/capacity_unit_calculator.h

src/server/available_detector.cpp

src/server/pegasus_server_impl.cpp

src/server/pegasus_write_service_impl.h

src/server/pegasus_server_impl.h

src/server/pegasus_write_service_impl.h

src/server/capacity_unit_calculator.h

src/server/pegasus_server_impl.cpp

src/server/capacity_unit_calculator.cpp

src/server/pegasus_server_impl.cpp

src/server/info_collector.h

src/server/pegasus_server_impl.cpp

src/server/capacity_unit_calculator.cpp

src/server/config-server.ini

src/server/config.ini

src/server/info_collector.cpp

src/server/capacity_unit_calculator.h

src/server/result_writer.cpp

src/server/available_detector.cpp

acelyc111 · 2019-05-09T08:40:20Z

src/server/result_writer.h

+    void set_result(const std::string &hash_key,
+                    const std::string &sort_key,
+                    const std::string &value,
+                    int try_count = 300);


try_count作为这个类构造函数传进去吧, 这个函数的参数去掉

async_set 的回调函数也要调用set_result，这个参数还不能去掉

不去掉, 把它放在result_writer构造函数参数里, 看调用都是固定的一个值, 写成函数内部的常量都行

这里try_count默认值是300，不一定要固定吧。

src/server/capacity_unit_calculator.h

src/server/pegasus_write_service.cpp

src/server/result_writer.cpp

src/shell/command_helper.h

acelyc111 · 2019-05-20T02:43:38Z

引用的rdsn commit id更新下

src/server/available_detector.h

src/server/result_writer.h

src/server/result_writer.cpp

src/server/info_collector.cpp

src/server/pegasus_server_impl.cpp

src/server/capacity_unit_calculator.h

src/server/pegasus_server_impl.cpp

src/server/available_detector.cpp

src/server/capacity_unit_calculator.h

src/server/capacity_unit_calculator.cpp

src/server/test/capacity_unit_calculator_test.cpp

acelyc111 · 2019-05-27T08:15:13Z

跟master有冲突, rebase一下master

Former-commit-id: 31812d21797dbf8d4ab622e4633f093f24d749b9 [formerly fa8ae10] Former-commit-id: d202d192c7d62378bb943bcf6cebbb6eb7624255

neverchanje requested review from qinzuoyan, acelyc111, neverchanje, hycdong, mentoswang and vagetablechicken April 15, 2019 04:31

neverchanje reviewed Apr 16, 2019

View reviewed changes

src/shell/command_helper.h Outdated Show resolved Hide resolved

src/server/info_collector.cpp Outdated Show resolved Hide resolved

src/server/info_collector.h Outdated Show resolved Hide resolved

src/server/info_collector.cpp Show resolved Hide resolved

acelyc111 reviewed Apr 16, 2019

View reviewed changes

qinzuoyan reviewed Apr 17, 2019

View reviewed changes

src/server/info_collector.cpp Outdated Show resolved Hide resolved

src/server/pegasus_server_impl.cpp Outdated Show resolved Hide resolved

src/server/pegasus_server_impl.cpp Outdated Show resolved Hide resolved

neverchanje reviewed Apr 19, 2019

View reviewed changes

src/server/pegasus_server_impl.h Outdated Show resolved Hide resolved

qinzuoyan reviewed Apr 24, 2019

View reviewed changes

neverchanje reviewed Apr 25, 2019

View reviewed changes

src/server/capacity_unit_calculator.h Outdated Show resolved Hide resolved

neverchanje reviewed Apr 25, 2019

View reviewed changes

src/server/pegasus_write_service_impl.h Outdated Show resolved Hide resolved

neverchanje reviewed Apr 25, 2019

View reviewed changes

src/server/available_detector.cpp Outdated Show resolved Hide resolved

qinzuoyan reviewed Apr 25, 2019

View reviewed changes

src/server/info_collector.h Outdated Show resolved Hide resolved

src/server/pegasus_server_impl.cpp Outdated Show resolved Hide resolved

qinzuoyan reviewed Apr 25, 2019

View reviewed changes

neverchanje reviewed Apr 26, 2019

View reviewed changes

src/server/capacity_unit_calculator.h Outdated Show resolved Hide resolved

acelyc111 reviewed May 9, 2019

View reviewed changes

neverchanje reviewed May 22, 2019

View reviewed changes

acelyc111 reviewed May 22, 2019

View reviewed changes

src/server/available_detector.cpp Show resolved Hide resolved

src/server/capacity_unit_calculator.h Outdated Show resolved Hide resolved

src/server/capacity_unit_calculator.cpp Outdated Show resolved Hide resolved

src/server/capacity_unit_calculator.cpp Outdated Show resolved Hide resolved

neverchanje force-pushed the cu_stat branch from 2212e06 to 64ec7a5 Compare May 23, 2019 03:33

neverchanje reviewed May 24, 2019

View reviewed changes

src/server/test/capacity_unit_calculator_test.cpp Outdated Show resolved Hide resolved

neverchanje mentioned this pull request May 24, 2019

Release 1.11.4 #330

Closed

10 tasks

neverchanje previously approved these changes May 24, 2019

View reviewed changes

张一帆 and others added 17 commits May 28, 2019 11:56

fix

3bb32cf

fix write cu calculation

7fe64c8

add result result_writer

de34551

fix

833d274

fix

16c254c

fix cu calculator

adc67ca

fix

45808a0

fix

4f20465

fix

a8987cb

add test framework

12a57a6

fix capacity_unit_calculator

28a63e6

correct unit test

e752cad

add unit test

641b9ad

fix

6dbad18

enhance unit test of capacity_unit

49407c3

fix comments and header includes

85e62e7

fix conflict

f33ccf1

zhangyifan27 dismissed neverchanje’s stale review via f33ccf1 May 28, 2019 04:28

zhangyifan27 force-pushed the cu_stat branch from e32c94a to f33ccf1 Compare May 28, 2019 04:28

acelyc111 approved these changes May 28, 2019

View reviewed changes

neverchanje approved these changes May 30, 2019

View reviewed changes

neverchanje merged commit fa8ae10 into apache:master May 30, 2019

neverchanje added component/monitor labels May 30, 2019

neverchanje pushed a commit that referenced this pull request May 30, 2019

*:support capacity unit read/write statistics (#318)

f657bbf

qinzuoyan mentioned this pull request Jun 18, 2019

server: improve capacity unit calculation #339

Merged

neverchanje pushed a commit that referenced this pull request Jul 1, 2019

*:support capacity unit read/write statistics (#318)

123f6d3

neverchanje added the 1.11.4 label Sep 21, 2019

WHBANG mentioned this pull request Aug 15, 2022

Make cu_calculator a switch control #1107

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*:support capacity unit read/write statistics #318

*:support capacity unit read/write statistics #318

zhangyifan27 commented Apr 15, 2019

acelyc111 commented Apr 18, 2019

acelyc111 May 9, 2019

zhangyifan27 May 15, 2019

acelyc111 May 17, 2019

zhangyifan27 May 22, 2019

acelyc111 commented May 20, 2019

acelyc111 commented May 27, 2019

*:support capacity unit read/write statistics #318

*:support capacity unit read/write statistics #318

Conversation

zhangyifan27 commented Apr 15, 2019

acelyc111 commented Apr 18, 2019

acelyc111 May 9, 2019

Choose a reason for hiding this comment

zhangyifan27 May 15, 2019

Choose a reason for hiding this comment

acelyc111 May 17, 2019

Choose a reason for hiding this comment

zhangyifan27 May 22, 2019

Choose a reason for hiding this comment

acelyc111 commented May 20, 2019

acelyc111 commented May 27, 2019