Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP service for replica server #360

Merged
merged 8 commits into from
Aug 7, 2019
Merged

Conversation

Skysheepwang
Copy link
Contributor

What problem does this PR solve?

add arguments for replica http service

What is changed and how it works?

add PEGASUS_VERSION and PEGASUS_GIT_COMMIT as arguments of http_service.start()

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

acelyc111
acelyc111 previously approved these changes Jul 26, 2019
@acelyc111 acelyc111 merged commit 1bcc911 into apache:master Aug 7, 2019
@neverchanje neverchanje mentioned this pull request Oct 29, 2019
acelyc111 pushed a commit that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants