Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change mymysql to go-sql-driver/mysql #133

Closed
martianzhang opened this issue Nov 27, 2018 · 1 comment
Closed

change mymysql to go-sql-driver/mysql #133

martianzhang opened this issue Nov 27, 2018 · 1 comment
Labels
suggest

Comments

@martianzhang
Copy link
Contributor

martianzhang commented Nov 27, 2018 •
edited

Feature Description

  • Considering go-sql-driver/mysql keep updating.
  • use go-sql-driver/mysql buildind FormatDSN for command line xxx-dsn format
  • get ready for SQL executing with SOAR.
  • mymysql can't pass go test -race

New branch go-sql-driver for this issue.
@Linkyang953
Copy link

看到目前soar master分支用的是ziutek的mymysql包，go-sql-driver分支用的是go-sql-driver包，请问这两个包各有何利弊，从长期来说soar会选择哪个包作为主要分支的依赖包呢？ @martianzhang

@martianzhang martianzhang mentioned this issue Dec 20, 2018
Closed
@martianzhang martianzhang added suggest and removed todo labels Dec 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
suggest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martianzhang @Linkyang953