Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making SurrogateRsq work for glm models #6

Closed
amrosicka opened this issue Jun 9, 2023 · 3 comments
Closed

Making SurrogateRsq work for glm models #6

amrosicka opened this issue Jun 9, 2023 · 3 comments

Comments

@amrosicka
Copy link

Hello, are you planning to make the surr_rsq function work with glm() models?
Glm is explicitly mentioned in the accompanying paper but when I try to apply the function surr_rsq() to my glm model, I get the following error message:

Error in UseMethod("getDatafromModel") : 
  no applicable method for 'getDatafromModel' applied to an object of class "c('glm', 'lm')"

I really like the concept of surrogate R2 and would love to be able to use it for my analyses. Any update on this would be much appreciated! Thanks!

@XiaoruiZhu
Copy link
Owner

@may-the-bee It is great to hear the Surrogate R2 would be useful for your analyses. Sure, I'll double-check this issue and fix it soon. Thanks for your feedback.

@XiaoruiZhu
Copy link
Owner

XiaoruiZhu commented Jul 7, 2023

@may-the-bee I just want to let you know the issue has been fixed. For the binary response, the logit/probit models can be the models for the goodness of fit analysis using a surrogate R-squared measure. If you're using any other specific models for categorical data analysis and would like to adopt the Surrogate R-squared, please also let me know, I could develop corresponding features for this package. Thanks for your feedback.

@amrosicka
Copy link
Author

Thanks @XiaoruiZhu for the fix!

@XiaoruiZhu XiaoruiZhu pinned this issue Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants