Add DialectFoldInterface to AIE dialect #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenneuendorffer
approved these changes
Oct 5, 2021
fifield
force-pushed
the
fold_interface
branch
from
174cfb3
to
8533272
Compare
This is needed to contain the materialization of constants in mlir regions that are not isolated from above. It is used here for the AIE.core op. Without it the folder will move constants from AIE.core regions into the enclosing module.
fifield
force-pushed
the
fold_interface
branch
from
8533272
to
0fd35ce
Compare
fifield
added a commit
to fifield/mlir-aie
that referenced
this pull request
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to contain the materialization of constants in
mlir regions that are not isolated from above. It is used here
for the AIE.core op. Without it the folder will move constants
from AIE.core regions into the enclosing module.