Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ODS to add 'name' member to 'xilinx::AIE::AIEObjectFifoSubviewType' and other types #853

Closed
frederik-h opened this issue Dec 11, 2023 · 2 comments

Comments

@frederik-h
Copy link

It seems that some ODS information needs to be update because of recent LLVM changes.
I have tried to compile the nod.ai shark runtime with the iree-amd-aie plugin enabled. The latter uses this project. I got the following error:

In file included from /home/fharwath/wd/shark/SRT/third_party/llvm-project/mlir/include/mlir/IR/Types.h:12:
/home/fharwath/wd/shark/SRT/third_party/llvm-project/mlir/include/mlir/IR/TypeSupport.h:54:28: error: no member named 'name' in 'xilinx::AIE::AIEObjectFifoSubviewType'
   54 |                         T::name);

This is caused by LLVM commit 3dbac2c007c1 [mlir] Expose type and attribute names in the MLIRContext and abstract type/attr classes
.

@frederik-h frederik-h changed the title Update ODS to add 'name' member to xilinx::AIE::AIEObjectFifoSubviewType and other types Update ODS to add 'name' member to 'xilinx::AIE::AIEObjectFifoSubviewType' and other types Dec 11, 2023
@stephenneuendorffer
Copy link
Collaborator

Are you sure your tree is up to date? Because: #809 should have fixed this?

@frederik-h
Copy link
Author

Are you sure your tree is up to date? Because: #809 should have fixed this?

Thanks for the pointer to the commit and sorry for the confusion. The iree-amd-aie project has been using an older version of this project and I did not notice that you have already solved the problem. They have made various changes to their mlir-air and mlir-aie submodule and now it includes the fix and I can build it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants