Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epoch length? #3

Open
xfdywy opened this issue May 17, 2021 · 2 comments
Open

Epoch length? #3

xfdywy opened this issue May 17, 2021 · 2 comments

Comments

@xfdywy
Copy link

xfdywy commented May 17, 2021

Hi,

Thank you for your code. It is really helpful.

Could you please check the line 115 in the main_mbpo.py? Since start_step will become larger and larger, if the condition is cur_step >= start_step + epoch_length, the truth epoch_length will also become larger and larger. So, is it a bug? Should we use

cur_step >= args.epoch_length

Correct me if I am wrong.

Thanks

if cur_step >= start_step + args.epoch_length and len(env_pool) > args.min_pool_size:

`
cur_step = total_step - start_step

        if cur_step >= start_step + args.epoch_length and len(env_pool) > args.min_pool_size:
            break

`

@mickelliu
Copy link

I have the same question. Does not make sense to me.

@945716994
Copy link

I think this may instead by cur_step >= args.epoch_legnth ....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants