Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 Minor bugs in RTC_Show #23

Open
mikeprice99 opened this issue Nov 27, 2020 · 0 comments
Open

2 Minor bugs in RTC_Show #23

mikeprice99 opened this issue Nov 27, 2020 · 0 comments

Comments

@mikeprice99
Copy link

(Using T-Wristband-LSM9DS1.ino for line numbers ...)
In RTC_Show function:

1/
line 690 = tft.setTextColor(0xFBE0, TFT_BLACK); // Orange
but by setting background color the 'ghost' image is overwritten. So the line should be
tft.setTextColor(0xFBE0); // Orange

2/
line 704, setting the color for drawing the colon is in the wrong block, causing the colon to be displayed in the wrong color if the voltage has changed within the current minute.
currently =
if (ss % 2) { // Flash the colon
tft.setTextColor(0x39C4, TFT_BLACK);
xpos += tft.drawChar(':', xcolon, ypos, 7);
tft.setTextColor(0xFBE0, TFT_BLACK);
} else {
tft.drawChar(':', xcolon, ypos, 7);
}

should be
if (ss % 2) { // Flash the colon
tft.setTextColor(0x39C4, TFT_BLACK);
xpos += tft.drawChar(':', xcolon, ypos, 7);
} else {
tft.setTextColor(0xFBE0, TFT_BLACK);
tft.drawChar(':', xcolon, ypos, 7);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant