Fix __repr__ for And and Or matchers #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I cannot use the `And` matcher in my tests, since the test crashes if `mock` decides to print out the matcher using `__repr__`. It looks like the `__repr__` functions for `And` and `Or` incorrectly have the `value` attribute? I assume these haven't actually been used previously, since these two methods also reference `self.matchers` instead of the correct `self._matchers` (which would have been caught earlier if they were actually called). Let me know if the `value` arg is intended behaviour. It seems that the `value` arg is not used though, and it's highly unusual for `__repr__()` to have more args than just `self`.
|
This is absolutely a bug. Thanks for fixing it! |
|
I made a 0.2.2 release to include this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cannot use the
Andmatcher in my tests, since the test crashes ifmockdecides to print out the matcher using__repr__. It looks like the__repr__functions forAndandOrincorrectly have thevalueargument?I assume these haven't actually been used previously, since these two methods also reference
self.matchersinstead of the correctself._matchers(which would have been caught earlier if they were actually called).Let me know if the
valuearg is intended behaviour. It seems that thevaluearg is not used though, and it's highly unusual for__repr__()to have more args than justself.