Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't show messages if channel name has uppercase characters #223

Closed
Rik034 opened this issue Sep 28, 2022 · 6 comments
Closed

Doesn't show messages if channel name has uppercase characters #223

Rik034 opened this issue Sep 28, 2022 · 6 comments
Labels
area: backend Internal enhancements type: bug Something isn't working

Comments

@Rik034
Copy link

Rik034 commented Sep 28, 2022

Describe the bug:
If the channel name has uppercase letters in it, no messages are loaded.

To Reproduce:

  1. Either provide a channel with uppercase letters in it in the config or with -c
  2. Run twt
  3. See bug

Screenshots:
test
Left side is twt -c xqc, right side is twt -c xQc

System:

  • Twitch-tui version: tested on 1.6.0, 2.0.0-alpha.11

  • Operating System: Arch Linux w/ kernel 5.19.11-xanmod1-1-x64v2

  • Terminal: alacritty 0.10.1

  • Shell: zsh 5.9

Additional context:
I pipe this script to see which channels that I follow are online into dmenu to open twt and streamlink. The channel name given by that script is the name that shows up on twitch, so it might have uppercase letters. It's not a big deal, I just convert the uppercase letters to lowercase in my dmenu script, but I was wondering what causes this issue, because in the logs it says that it connected to the irc channel and it even shows the info (like follower mode, slow mode etc.)

@github-actions
Copy link

Thank you for the issue! This issue will be addressed in a reasonable amount of time.

@Xithrius
Copy link
Owner

Xithrius commented Sep 28, 2022

Very interesting, I'll see what's causing this problem internally.

Thanks for submitting this issue!

@Xithrius
Copy link
Owner

Xithrius commented Sep 28, 2022

According to this Twitch developers post, when joining an IRC channel, the characters in a channel name have to be lowercase.

I'll make a hotfix, and it'll be put out in the next release (very soon).

The exact issue internally comes from this line which takes the config value and directly puts it into the IRC config.

@Xithrius Xithrius added type: bug Something isn't working area: backend Internal enhancements labels Sep 28, 2022
@Rik034
Copy link
Author

Rik034 commented Sep 28, 2022

According to this Twitch developers post, when joining an IRC channel, the characters in a channel name have to be lowercase.

I thought it might be something along those lines.
Thanks for the quick reply!

@Xithrius
Copy link
Owner

Xithrius commented Sep 28, 2022

No problem.

In terms of frontend, do you think that the channel title at the top of the window should reflect Twitch's IRC channel rule, or should it reflect what the user inputs?

In my opinion, it should reflect what Twitch enforces.

@Xithrius
Copy link
Owner

I've gone with the option of lowercase channels in the title. This was implemented in ab6f2af.

This hotfix is included with the state tabs feature in release v2.0.0-alpha.12.

Thank you for catching this issue, have a good one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend Internal enhancements type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants