Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug-Report] [1.3.19] Massive increase in max script update time after updating #40

Closed
1 task
Bluebottle39 opened this issue Jul 15, 2023 · 8 comments
Closed
1 task
Assignees
Labels
bug Something isn't working

Comments

@Bluebottle39
Copy link

Bluebottle39 commented Jul 15, 2023

Bug Report

  • old graphite fuel setting enabled ?
    No

Describe the bug

Updating from version 1.3.18 to 1.3.19 has massively increased the max script update time. Average and min time very low though. Manifests as lag spikes.

How to reproduce

just update version. When i downgrade the problem goes away

Your Idea on how to fix it

Additional information

I am using a pretty big mod list

factorio_3tTZXGLvCC

Exported mod list from modmyfactory2
testing.fmp.txt

If you need any other information I will add

@Bluebottle39 Bluebottle39 added the bug Something isn't working label Jul 15, 2023
@Xman1109
Copy link
Owner

I know what's causing this, but the people on the factorio discord told me this wouldn't be a big issue.
I will fix it by tomorrow or Monday.

Thanks for informing me about this.

@Bluebottle39
Copy link
Author

Bluebottle39 commented Jul 15, 2023

Thank you for the very fast response!
Thank you for all the work on the mod, love it!

@Xman1109
Copy link
Owner

Xman1109 commented Jul 17, 2023

I updated the mod to include a setting named " Heat Accumulator script " if it gets turned off then the lag spikes should vanish, so let me know if that works for you.

@Bluebottle39
Copy link
Author

That works for me.
Will the heat accumulators still work without the script? What does it do?

@Xman1109
Copy link
Owner

Glad it worked!

The heat accumulator checks every 10 seconds if a coated fluid tank is on a surface and if it has over 24500 Units of heating oil in it, if so the script will convert it into heat accumulator, which does what is says.

@Bluebottle39
Copy link
Author

Sounds like they won't work without the script then?

in any case thanks for the fix, it's much appreciated!

@Xman1109
Copy link
Owner

Well, I've made it so that you can craft everything, it just does not have its functionality.
But you can fill some tanks and restart the game with this setting on, so that it converts it to a heat accumulator, then restart with the script turned off.

The way it is now is just a temporary solution. I may change it in the future, for example with a command, so it only checks 1 time after executing it, or maybe a recipe to fill the tank if the setting is turned off.

@Bluebottle39
Copy link
Author

Wonderful, thanks for the clarification.
I'm happy to close this issue now if you are?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants