Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paint scroll using the offscreen decode worker #231

Open
totaam opened this issue Mar 14, 2023 · 2 comments
Open

paint scroll using the offscreen decode worker #231

totaam opened this issue Mar 14, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@totaam
Copy link
Collaborator

totaam commented Mar 14, 2023

It is currently disabled since it causes visual corruption: #217 (comment)

@totaam
Copy link
Collaborator Author

totaam commented Mar 14, 2023

scroll draw packets always come first so we only have to ensure that all the previous draw packets have been decoded by the ImageDecoder before we can process a scroll draw.
(I think that we can ignore video because that's usually not used with scroll - or at least, let's deal with that later)

Every draw packet has a sequence number in it, so we can just keep track of the sequence numbers we have submitted for decoding and pop them out when we get the result (or better still: after the paintworker has updated the canvas)
What I don't know how to do is how to asynchronously wait for this sequence number list to become empty.

@totaam totaam added the enhancement New feature or request label Mar 31, 2023
@totaam
Copy link
Collaborator Author

totaam commented Feb 25, 2024

Perhaps this bug fix helps: Xpra-org/xpra@ff36bc1
Having the wrong flush value would have stalled the updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants