move websockify in the xpra process

[totaam]

Issue migrated from trac ticket # 1136

component: server | priority: major | resolution: fixed

2016-02-25 02:55:03: antoine created the issue

---

So we don't have to exec anything, then we also won't be needing the proxy instance running xpra side (which is forwarding to and from the websockify process, using 2 threads).
See also #1134.

[totaam]

2016-03-16 06:14:47: antoine changed status from new to assigned

[totaam]

2016-05-24 17:27:06: antoine uploaded file websockify-inprocess.patch (22.0 KiB)

move websockify handling in process

[totaam]

2016-05-24 17:30:58: antoine commented

---

The patch above works fine, only left todo:

• handle html=/path/to/www and generate / detect correct path (ie: on osx, in the app bundle)
• TLS setup
• man page updates
• test tcp-proxy mode better
• use the peek function to avoid creating a whole protocol instance (and threads) if the packet header is invalid
• verify blocking sockets and timeout values

[totaam]

2016-05-26 16:35:15: antoine commented

---

Mostly done in r12688. Firefox is still having problems, but that doesn't seem to be anything new.
Still todo:

• TLS
• bail out early on invalid packet header

[totaam]

2016-05-30 13:04:47: antoine uploaded file web-ssl.patch (10.9 KiB)

attempts at preventing ssl from deadlocking - failed

[totaam]

2016-05-30 13:11:28: antoine changed status from assigned to new

[totaam]

2016-05-30 13:11:28: antoine changed owner from antoine to afarr

[totaam]

2016-05-30 13:11:28: antoine commented

---

• r12708 fixes an error with win32 servers (but win32 servers still don't support the html5 client: websockify and named pipe timeouts on win32 #1211)
• r12699 bails out early
• I give up on SSL for now - will follow up in http / websockify ssl support #1213, the patch above tries to use a thread as early as possible, setting timeouts on the sockets, raising the number of sockets we create, etc.. to no avail

---

@afarr: the html client should be faster now

[totaam]

2016-06-24 22:26:16: maxmylyn commented

---

HTML client is by far faster. It's like night and day faster now.

I'd say performance in Chrome is 90% as good as Python.

[totaam]

2016-06-24 22:28:38: maxmylyn changed status from new to closed

[totaam]

2016-06-24 22:28:38: maxmylyn set resolution to fixed

[totaam]

2016-06-24 22:28:38: maxmylyn commented

---

Oh, sorry, I hit submit without thinking.

Closing.

[totaam]

2016-07-12 17:52:23: antoine commented

---

Milestone renamed