Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential DOS #130

Closed
totaam opened this issue May 26, 2012 · 5 comments
Closed

Potential DOS #130

totaam opened this issue May 26, 2012 · 5 comments

Comments

@totaam
Copy link
Collaborator

totaam commented May 26, 2012

Issue migrated from trac ticket # 130

component: server | priority: major | resolution: fixed

2012-05-26 22:42:22: http://norman.rasmussen.co.za/ created the issue


If you connect 20 connections within 10 seconds, and don't send a hello packet, then the server will close the listening socket.

The error is because the listening socket is closed, and instead accept should be called, and the returned socket should be closed instead.

I will attach a proposed fix.

@totaam
Copy link
Collaborator Author

totaam commented May 26, 2012

2012-05-26 22:44:49: http://norman.rasmussen.co.za/ uploaded file ticket-130.patch (1.2 KiB)

@totaam
Copy link
Collaborator Author

totaam commented May 26, 2012

2012-05-26 23:21:58: http://norman.rasmussen.co.za/ changed component from android to server

@totaam
Copy link
Collaborator Author

totaam commented May 27, 2012

2012-05-27 15:46:18: antoine changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented May 27, 2012

2012-05-27 15:46:18: antoine changed resolution from ** to fixed

@totaam
Copy link
Collaborator Author

totaam commented May 27, 2012

2012-05-27 15:46:18: antoine commented


applied in r872

@totaam totaam closed this as completed May 27, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant