Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digitally sign the installer #1499

Closed
totaam opened this issue Apr 13, 2017 · 8 comments
Closed

Digitally sign the installer #1499

totaam opened this issue Apr 13, 2017 · 8 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Apr 13, 2017

Issue migrated from trac ticket # 1499

component: client | priority: minor | resolution: fixed | keywords: win32

2017-04-13 00:43:14: andrewmunn created the issue


Can the installation binary be digitally signed going forward? I think this will help the application get past some corporate security policies once the signing key is whitelisted there.

@totaam
Copy link
Collaborator Author

totaam commented Apr 13, 2017

2017-04-13 08:23:05: @totaam uploaded file xpra-ca.cer (0.8 KiB)

self signed CA cert

@totaam
Copy link
Collaborator Author

totaam commented Apr 13, 2017

2017-04-13 08:24:13: antoine uploaded file install-xpra-ca.png (26.7 KiB)

warning shown when installing the xpra ca file
install-xpra-ca.png

@totaam
Copy link
Collaborator Author

totaam commented Apr 13, 2017

2017-04-13 08:24:33: antoine uploaded file UAC-warning-verified-publisher.png (35.5 KiB)

UAC warning when installing the signed application
UAC-warning-verified-publisher.png

@totaam
Copy link
Collaborator Author

totaam commented Apr 13, 2017

I assume that you are talking about MS Windows installers.

That's now done in r15584 based on the instructions found in How do I create a self-signed certificate for code signing on Windows?.

Note: you will need to install the xpra-ca.cer self signed CA file first using:

certutil -user -addstore Root xpra-ca.cer

You will get a warning that looks like this the first image above.

But then when installing the application, the UAC dialog will look less threatening. (second image)

There are signed windows beta builds you can test: [http://xpra.org/beta/windows].
@andrewmunn: please close this ticket if that works for you.

Ultimately, we should use a proper CA, but at ~$160 per year. Those don't come cheap.
One benefit of those certificates is that they are apparently trusted on Mac OSX too, so we wouldn't have to pay the apple developer fee to get the PKG / DMG signed (the apple developer account key has now expired, that was complete waste of money: see #1340).

@totaam
Copy link
Collaborator Author

totaam commented Apr 17, 2017

Minor build system update: r15642

@totaam
Copy link
Collaborator Author

totaam commented May 11, 2017

Not heard back, closing.

@totaam totaam closed this as completed May 11, 2017
@totaam
Copy link
Collaborator Author

totaam commented Dec 19, 2021

See also #3340

@totaam
Copy link
Collaborator Author

totaam commented Sep 6, 2023

See also #3923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant