Latest OSX client GTK traceback

[totaam]

Issue migrated from trac ticket # 1746

component: client | priority: blocker | resolution: fixed

2018-01-17 18:07:41: maxmylyn created the issue

---

Using the latest trunk r17825 client, I am unable to attach to my Fedora 26 trunk r18032 server. The client produces the following traceback and then fails to attach:

/Users/max/Desktop/xpradists/[r17825](../commit/ae26ef14eb6f79d43a31384706b79d88cfe209b0)/Xpra.app/Contents/Resources/lib/python/xpra/platform/darwin/gui.py:95: Warning: invalid cast from 'GtkMenuBar' to 'GtkWindow'
  osxapp.set_menu_bar(mh.rebuild())
/Users/max/Desktop/xpradists/[r17825](../commit/ae26ef14eb6f79d43a31384706b79d88cfe209b0)/Xpra.app/Contents/Resources/lib/python/xpra/platform/darwin/gui.py:95: GtkWarning: gtk_window_add_accel_group: assertion 'GTK_IS_WINDOW (window)' failed
  osxapp.set_menu_bar(mh.rebuild())
xpra main error:
Traceback (most recent call last):
  File "/Users/max/Desktop/xpradists/[r17825](../commit/ae26ef14eb6f79d43a31384706b79d88cfe209b0)/Xpra.app/Contents/Resources/lib/python/xpra/scripts/main.py", line 175, in main
    return run_mode(script_file, err, options, args, mode, defaults)
  File "/Users/max/Desktop/xpradists/[r17825](../commit/ae26ef14eb6f79d43a31384706b79d88cfe209b0)/Xpra.app/Contents/Resources/lib/python/xpra/scripts/main.py", line 1503, in run_mode
    return run_client(error_cb, options, args, mode)
  File "/Users/max/Desktop/xpradists/[r17825](../commit/ae26ef14eb6f79d43a31384706b79d88cfe209b0)/Xpra.app/Contents/Resources/lib/python/xpra/scripts/main.py", line 2452, in run_client
    app = get_client_app(error_cb, opts, extra_args, mode)
  File "/Users/max/Desktop/xpradists/[r17825](../commit/ae26ef14eb6f79d43a31384706b79d88cfe209b0)/Xpra.app/Contents/Resources/lib/python/xpra/scripts/main.py", line 2530, in get_client_app
    app = make_client(error_cb, opts)
  File "/Users/max/Desktop/xpradists/[r17825](../commit/ae26ef14eb6f79d43a31384706b79d88cfe209b0)/Xpra.app/Contents/Resources/lib/python/xpra/scripts/main.py", line 2591, in make_client
    toolkit_module = __import__(client_module, globals(), locals(), ['XpraClient'])
  File "/Users/max/Desktop/xpradists/[r17825](../commit/ae26ef14eb6f79d43a31384706b79d88cfe209b0)/Xpra.app/Contents/Resources/lib/python/xpra/client/gtk2/client.py", line 21, in <module>
    from xpra.client.gtk2.client_window import ClientWindow
  File "/Users/max/Desktop/xpradists/[r17825](../commit/ae26ef14eb6f79d43a31384706b79d88cfe209b0)/Xpra.app/Contents/Resources/lib/python/xpra/client/gtk2/client_window.py", line 11, in <module>
    from xpra.client.gtk2.gtk2_window_base import GTK2WindowBase
  File "/Users/max/Desktop/xpradists/[r17825](../commit/ae26ef14eb6f79d43a31384706b79d88cfe209b0)/Xpra.app/Contents/Resources/lib/python/xpra/client/gtk2/gtk2_window_base.py", line 33, in <module>
    DISPLAY_HAS_SCREEN_INDEX = os.environ.get("DISPLAY").split(":")[-1].find(".")>=0
AttributeError: 'NoneType' object has no attribute 'split'

Blocker for #1157

[totaam]

2018-01-17 23:23:18: antoine changed status from new to closed

[totaam]

2018-01-17 23:23:18: antoine set resolution to fixed

[totaam]

2018-01-17 23:23:18: antoine commented

---

This particular bug had been fixed in r17852.

You can workaround it by running xpra with:

DISPLAY=whatever Xpra attach ...

Until I can make newer builds.

[totaam]

2018-01-18 01:27:46: antoine commented

---

New beta builds posted: [https://xpra.org/beta/osx/]

Note: unless you are testing recent 2.3 features, most other builds have everything needed.