Automated Tests missing data

[totaam]

Issue migrated from trac ticket # 2112

component: tests | priority: major | resolution: fixed

2019-01-21 18:11:28: maxmylyn created the issue

---

As mentioned in #619, #1840, and #2064, the automated tests are missing a handful of data points. From #1840#comment:6, most of the useful data points such as batch delay, quality, et al aren't included in the CSV. As far as I can tell, there's no error or traceback printed when the tests run xpra info, so it's likely that the Xpra Info page has changed, as is mentioned. The test code will likely need to be updated to reflect these changes.

[totaam]

2019-01-22 06:12:53: antoine changed status from new to assigned

[totaam]

2019-01-22 06:12:53: antoine commented

---

I'm pretty sure the data collection breakage is fairly recent, whereas these tickets are not, so you should be able to test the version they were completed for:

• better TCP_NODELAY handling: only use it when it is useful #619 was completed for 2.3
• tune x264 threading #1840 was completed for 2.4

[totaam]

2019-03-04 09:12:54: antoine commented

---

Wow, this whole thing is in terrible shape.
Minor cleanup in r21958.
Bug fix in r21959. Now at least some of the tests do run.

Now the real problem with the missing data is the same thing that required fixes to the session info dialog (r21340).

As of r21960, we capture the batch delay again, more fixes needed.

[totaam]

2019-03-04 13:05:28: antoine commented

---

As of r21962, the actual batch delay is back (but now this is a normalized value... and maybe this should not be compared?), as well as the latency values.

Still need to restore:

• packets/s in and out
• application packets/s
• speed and quality

[totaam]

2019-03-07 08:38:08: antoine commented

---

• r21996 fixes the packet counters
• r21997 fixes speed and quality data collection

[totaam]

2019-03-07 09:16:57: antoine changed status from assigned to new

[totaam]

2019-03-07 09:16:57: antoine changed owner from antoine to encodedEntropy

[totaam]

2019-03-07 09:16:57: antoine commented

---

r21998 reverts some of the "actual batch delay" changes from r21960 + r21962 so that the values will be more in line with older versions.

Should now be usable again and the data should make sense.

[totaam]

2019-08-01 13:01:50: smo changed owner from encodedEntropy to smo

[totaam]

2019-08-02 13:35:27: smo uploaded file test.csv (3.4 KiB)

tests data from browser test

[totaam]

2019-08-02 13:38:24: smo commented

---

I attached some data from some browser tests. Still seems to be some missing data points.

download limit (KB), upload limit (KB), latency (ms) all read 0 for example

Can you take a look and let me know?

[totaam]

2019-08-02 13:38:39: smo changed owner from smo to Antoine Martin

[totaam]

2019-08-03 16:01:30: antoine changed owner from Antoine Martin to smo

[totaam]

2019-08-03 16:01:30: antoine commented

---

Still seems to be some missing data points.
download limit (KB), upload limit (KB), latency (ms) all read 0 for example
Those are test configuration options for trickle.
They should be showing up if you enable it.

[totaam]

2019-08-07 02:14:39: smo changed status from new to closed

[totaam]

2019-08-07 02:14:39: smo set resolution to fixed

[totaam]

2019-08-07 02:14:39: smo commented

---

Confirmed the missing data does show up when you turn on the trickle options.