pylint warnings

[totaam]

Issue migrated from trac ticket # 2155

component: core | priority: major | resolution: fixed

2019-02-19 04:57:46: antoine created the issue

---

Some of those uncover real bugs, let's try to trim the output (over 10000 warnings is a bit much!) and fix the real bugs.

[totaam]

2019-02-19 05:01:47: antoine changed status from new to assigned

[totaam]

2019-02-19 05:01:47: antoine commented

---

The pylint suppression rules I am using right now:

--ignore-patterns=.*.c --ignore-patterns=.*.html --ignore-patterns=.*pyx --ignore-patterns=.*pxi
--good-names=x,y,w,h,v,n,i,e,log,d  --max-line-length=120
--disable=C0111 --disable=C0103 --disable=F0401 --disable=W0201
--disable=R0205 --disable=R0201 --disable=C1001 --disable=W0703
--disable=W0603

Some of the fixes already committed:

• r21692
• r21689
• r21688
• r21686
• r21684
• r21683
• r21681
• r21679
• r21678
• r21675
• r21674
• r21664
• r21663
• r21662

[totaam]

2019-02-19 07:53:13: antoine commented

---

• r21693
• r21696
• r21697
• r21698
• r21699
• r21700

[totaam]

2019-02-20 04:14:24: antoine commented

---

• 21701 (backport for bugs)
• r21702 (whitespace)
• r21703 FIX for incorrect pylint conversion
• r21704
• r21706
• r21707
• r21711
• r21712
• r21713
• r21714
• r21716
• r21717
• r21718 real BUG found (21719 backport)
• r21720 - partially reverted in r21728
• r21722
• r21723
• r21726
• r21727

[totaam]

2019-02-26 03:57:08: antoine commented

---

More:

• r21733 fix regression
• r21735
• r21736
• r21742
• r21743
• r21746
• r21748
• r21749 - problematic, then r21759 was the wrong fix, correct fix in r21782
• r21750 real bug
• r21751 real bug
• r21752
• r21755 (more resilient code)
• r21756
• r21757
• r21758 real bug, rpc code unused?
• r21761
• r21762
• r21765
• r21766 real bug
• r21767
• r21768 real bug
• r21770, r21771: whitespace
• r21772
• r21773
• r21774: removed remnants of win XP support
• r21775
• r21776
• r21783
• r21787, r21788 fixups for incorrect changesets
• r21795 avoids potential race conditions
• r21796
• r21797
• r21798
• r21799
• r21801
• r21802
• r21803 (was problematic - fixed later)
• r21811 real bug
• r21812
• r21813 buggy fix
• r21819
• r21821
• r21822
• r21823
• r21824: utf8, the rare few places where we actually care about encoding (strings vs bytes)
• r21825 real bug
• r21826
• r21827 fixup
• r21835
• r21843 real bug
• r21845
• r21848
• r21849 real bug
• r21850
• r21851
• r21852 real bug
• r21853
• r21854
• r21865 real bug
• r21866

See also #2177

[totaam]

2019-03-07 12:55:57: antoine changed status from assigned to closed

[totaam]

2019-03-07 12:55:57: antoine set resolution to fixed

[totaam]

2019-03-07 12:55:57: antoine commented

---

More, some reported by PYTHONWARNINGS=all:

• r21871, r21897, r21987: fixup regressions caused by stricter exception checking
• r21872
• r21881: file leak
• r21882: threads_init cleanup
• r21890
• r21902
• r21903
• r21904
• r21907
• r21912
• r21913
• r21914
• r21923
• r21925
• r21928
• r21944
• r21958
• r21965
• r21967
• r21968
• r21969