Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xpra shadow: on client window maximize, (down)scale the shadowed screen to "perfectly fit" the new window geometry #2458

Open
totaam opened this issue Oct 20, 2019 · 4 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Oct 20, 2019

Issue migrated from trac ticket # 2458

component: client | priority: minor

2019-10-20 13:31:24: stdedos created the issue


Attempt to almost imitate the RDP protocol.

I would guess that changing the underlaying resolution would be way too complicated, since the monitors are attached to physical monitors.

When maximizing the client (or going full screen), attempt to scale the image perfectly to size (optionally, give the option to add black bars to avoid weird stretching).

Note that the scale "you" are doing might be better than the OpenGL scaling (text is unreadable, there are too many artifacts)

@totaam
Copy link
Collaborator Author

totaam commented Oct 20, 2019

Previously discussed in #2455 where some screenshots can be found.

Note that the scale "you" are doing might be better than the OpenGL scaling (text is unreadable, there are too many artifacts)

I don't understand this bit. OpenGL scaling is not meant to give any artifacts. There may be a slight blur with non whole integer scaling, but when scaling by 200%, it should be "pixel perfect" - which just means you get jagged edges.

@totaam
Copy link
Collaborator Author

totaam commented Oct 20, 2019

Note that the scale "you" are doing might be better than the OpenGL scaling (text is unreadable, there are too many artifacts)

I don't understand this bit. OpenGL scaling is not meant to give any artifacts. There may be a slight blur with non whole integer scaling, but when scaling by 200%, it should be "pixel perfect" - which just means you get jagged edges

Apologies, I keep forgetting to mention everything all the time 😅.

My usecase is scaling down, not up. (Q)HD to 1366x768 screen

@totaam
Copy link
Collaborator Author

totaam commented Oct 20, 2019

My usecase is scaling down, not up. (Q)HD to 1366x768 screen

Right, in that case you also need #2052 to save tons of network traffic and use a high quality downscaling algorithm.

See also #530.

@totaam totaam added this to the 4.2 milestone Jan 23, 2021
@totaam totaam added this to High priority in geometry issues Jan 24, 2021
@stdedos stdedos changed the title xpra shadow: on client maximize, scale the other screen "perfectly" xpra shadow: on client maximize, (down)scale the other screen "perfectly" Sep 4, 2023
@stdedos stdedos changed the title xpra shadow: on client maximize, (down)scale the other screen "perfectly" xpra shadow: on client window maximize, (down)scale the shadowed screen to "perfectly fit" the new window geometry Sep 4, 2023
@stdedos
Copy link
Collaborator

stdedos commented Sep 4, 2023

I assume this is a priority at the second-tier? (i.e., after #3948)

Should we use this to track only downscaling (as it was original), or upscaling too?

I assume that after #3140 --desktop-scaling should accept any float value.
The "kicker" would be to do the math, per geometry-change, and handle the N monitors shadowing (if at all possible)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
geometry issues
High priority
Development

No branches or pull requests

2 participants