Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3 setup.py sdist --formats=gztar does not include xxh3.h #2512

Closed
totaam opened this issue Dec 12, 2019 · 4 comments
Closed

python3 setup.py sdist --formats=gztar does not include xxh3.h #2512

totaam opened this issue Dec 12, 2019 · 4 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Dec 12, 2019

Issue migrated from trac ticket # 2512

component: packaging | priority: trivial | resolution: fixed

2019-12-12 10:44:42: ozanty created the issue


I am working on build script for Slackware and I am using the trunk version for building. I prepare tarball for the script using the below command:

python3 setup.py sdist --formats=gztar

The tarball created is missing xxh3.h and the build fails.

gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -O2 -fPIC -fPIC -Ixpra/buffers -I/usr/include/python3.7m -c xpra/buffers/xxhash.c -o build/temp.linux-x86_64-3.7/xpra/buffers/xxhash.o -O3 -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wall -Werror -Wno-error=deprecated-declarations -fPIC -O2 -fPIC
xpra/buffers/xxhash.c:1105:10: fatal error: xxh3.h: No such file or directory
 1105 | #include "xxh3.h"
      |          ^~~~~~~~
compilation terminated.
error: command 'gcc' failed with exit status 1

I expected the xxh3.h to be included in the tarball as well.

@totaam
Copy link
Collaborator Author

totaam commented Dec 12, 2019

2019-12-12 10:51:43: antoine changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Dec 12, 2019

2019-12-12 10:51:43: antoine set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Dec 12, 2019

2019-12-12 10:51:43: antoine commented


Thanks for the report!

This is fixed in r24715.

More found in #2513.

@totaam totaam closed this as completed Dec 12, 2019
@totaam
Copy link
Collaborator Author

totaam commented Dec 12, 2019

2019-12-12 11:32:00: ozanty commented


Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant