Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xpra assumes all Linuxes have which installed, resulting in errors when its not #3216

Closed
miojonka opened this issue Jul 22, 2021 · 2 comments

Comments

@miojonka
Copy link
Contributor

Xpra currently checks for its own binary when connecting to a server by using which xpra. But it does not verify that the program which is actually installed (probably because many distributions make part of their base install).

This causes several problems:

  • not every distribution has which installed (it is not part of Archlinux base)
  • when which is not installed, xpra claims that Xpra is not installed instead upon connecting
  • which is not a proper way to find the path to a binary - command -v is. (POSIX)

#3215 should fix this.

@totaam
Copy link
Collaborator

totaam commented Jul 22, 2021

Out of curiosity, which OS are you running on?
which is installed on every distribution that I have used for testing.
Please see https://github.com/Xpra-org/xpra/pull/3215/files#r674875670

@miojonka
Copy link
Contributor Author

I'm running Archlinux (archlinux.org) which does not have which installed in it's base package.

@totaam totaam closed this as completed Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants