Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo / packaging logistics: Private key + arch #3726

Closed
stdedos opened this issue Jan 4, 2023 · 11 comments
Closed

Repo / packaging logistics: Private key + arch #3726

stdedos opened this issue Jan 4, 2023 · 11 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists packaging

Comments

@stdedos
Copy link
Collaborator

stdedos commented Jan 4, 2023

Should https://xpra.org/repos/bionic/xpra-beta.list match e.g. https://xpra.org/repos/bookworm/xpra-beta.list?

Similarly for https://xpra.org/repos/bionic/xpra.list

deb [ arch=amd64,arm64 signed-by=/usr/share/keyrings/xpra-2022.gpg ] https://xpra.org/ focal main
deb [ arch=amd64,arm64 signed-by=/usr/share/keyrings/xpra-2022.gpg ] https://xpra.org/beta/ focal main
@totaam totaam added bug Something isn't working packaging labels Jan 5, 2023
@totaam
Copy link
Collaborator

totaam commented Jan 5, 2023

Edit: Wait. I'm not seeing that.
Every /repos/distro/xpra[-beta].list should contain something.... https://xpra.org/[beta/] $distro main

@totaam
Copy link
Collaborator

totaam commented Jan 5, 2023

Are you referring to the gpg key location and using a different key for different distros?
That would be: #3539 (comment) and #3485 (comment)

@stdedos
Copy link
Collaborator Author

stdedos commented Jan 5, 2023

Edit: Wait. I'm not seeing that.

I only copy-pasted the fixed lines for your convenience. I'm sorry if it looked like I implied "this is how https://xpra.org/repos/bionic/xpra.list looks like" 😓

Are you referring to the gpg key location and using a different key for different distros?

I am saying that: bionic is the only release not containing [ arch=amd64,arm64 signed-by=/usr/share/keyrings/xpra-2022.gpg ].


... but now I remembered, bionic is 18.04, which means ... I cannot test if [ arch=amd64,arm64 signed-by=/usr/share/keyrings/xpra-2022.gpg ] is actually valid for bionic or not.

@stdedos
Copy link
Collaborator Author

stdedos commented Jan 5, 2023

It is, however, valid for focal, which is also missing [ arch=amd64,arm64 signed-by=/usr/share/keyrings/xpra-2022.gpg ]:

$ curl https://xpra.org/repos/focal/xpra.list
deb https://xpra.org/ focal main
$ curl https://xpra.org/repos/focal/xpra-beta.list
deb https://xpra.org/beta/ focal main

@ehfd
Copy link

ehfd commented Jan 19, 2023

#3539
This, I would say, is more painless. Same template for all recent versions from 18.04 to 22.10 and similar Debian versions.

@totaam
Copy link
Collaborator

totaam commented Jan 19, 2023

@stdedos I believe that it isn't present for focal, because it isn't needed there?

@ehfd
Copy link

ehfd commented Jan 19, 2023

I am saying that: bionic is the only release not containing [ arch=amd64,arm64 signed-by=/usr/share/keyrings/xpra-2022.gpg ].

This is actually invalid for bionic, and will error.

@ehfd
Copy link

ehfd commented Jan 19, 2023

I came back to #3539 because I was having the same issue when I needed uniformity for VS Code installation across versions.

@stdedos
Copy link
Collaborator Author

stdedos commented Jan 19, 2023

@stdedos I believe that it isn't present for focal, because it isn't needed there?

Depends on you definition of "needed", I guess. Ofc, I haven't verified "this" against a Canonical-clean Ubuntu Focal ISO, so (My) Milleage Might Vary

@stdedos
Copy link
Collaborator Author

stdedos commented Jan 19, 2023

#3539 This, I would say, is more painless. Same template for all recent versions from 18.04 to 22.10 and similar Debian versions.

"More or less painless" idk. Haven't used it ever, don't know how it works: Same-same-old-but-new to me.

apt-add-repository creates .list files (right now in my Ubuntu Focal at least), so ... I am using them anyway. Might as well have a "sane, secure, up-to-date" version of it.

@totaam
Copy link
Collaborator

totaam commented Mar 16, 2023

This is superseded by #3539 - right?

@totaam totaam closed this as not planned Won't fix, can't repro, duplicate, stale Mar 16, 2023
@stdedos stdedos added the duplicate This issue or pull request already exists label Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists packaging
Projects
None yet
Development

No branches or pull requests

3 participants