Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traceback found connecting osx 0.14.3 client session #677

Closed
totaam opened this issue Sep 12, 2014 · 5 comments
Closed

Traceback found connecting osx 0.14.3 client session #677

totaam opened this issue Sep 12, 2014 · 5 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Sep 12, 2014

Issue migrated from trac ticket # 677

component: client | priority: minor | resolution: fixed

2014-09-12 23:26:56: afarr created the issue


Connecting an osx 0.14.3 client using the command line I'm seeing the following traceback:

2014-09-12 15:22:20,145 renderer 'Intel HD Graphics 4000 OpenGL Engine' enabled (found in both blacklist and whitelist)
2014-09-12 15:22:20,158 OpenGL_accelerate module loaded
2014-09-12 15:22:20,159 Using accelerated ArrayDatatype
2014-09-12 15:22:20,191 make_instance[<class 'xpra.platform.darwin.osx_tray.OSXTray'>, <class 'xpra.client.gtk_base.statusicon_tray.GTKStatusIconTray'>, <gtk.MenuBar object at 0x635ec88 (GtkMenuBar at 0x196e0d8)>, u'tcp:10.0.32.188:1205', '', <function xpra_tray_geometry at 0xc79b4f0>, <function xpra_tray_click at 0xc761af0>, <function xpra_tray_mouseover at 0xc79b430>, <function xpra_tray_exit at 0xc79b4b0>] failed to instantiate <class 'xpra.platform.darwin.osx_tray.OSXTray'>
Traceback (most recent call last):
  File "/Users/spikesinc/gtk/inst/lib/python2.7/site-packages/xpra/client/ui_client_base.py", line 530, in make_instance
  File "/Users/spikesinc/gtk/inst/lib/python2.7/site-packages/xpra/platform/darwin/osx_tray.py", line 30, in __init__
  File "/Users/spikesinc/gtk/inst/lib/python2.7/site-packages/xpra/platform/darwin/osx_tray.py", line 84, in set_global_menu
  File "/Users/spikesinc/gtk/inst/lib/python2.7/site-packages/xpra/platform/darwin/osx_menu.py", line 97, in add_full_menu
TypeError: 'NoneType' object is not iterable
2014-09-12 15:22:20,220 make_instance[<class 'xpra.platform.darwin.osx_tray.OSXTray'>, <class 'xpra.client.gtk_base.statusicon_tray.GTKStatusIconTray'>, <gtk.MenuBar object at 0x635ec88 (GtkMenuBar at 0x196e0d8)>, u'tcp:10.0.32.188:1205', '', <function xpra_tray_geometry at 0xc79b4f0>, <function xpra_tray_click at 0xc761af0>, <function xpra_tray_mouseover at 0xc79b430>, <function xpra_tray_exit at 0xc79b4b0>] failed to instantiate <class 'xpra.client.gtk_base.statusicon_tray.GTKStatusIconTray'>
Traceback (most recent call last):
  File "/Users/spikesinc/gtk/inst/lib/python2.7/site-packages/xpra/client/ui_client_base.py", line 530, in make_instance
  File "/Users/spikesinc/gtk/inst/lib/python2.7/site-packages/xpra/client/gtk_base/statusicon_tray.py", line 38, in __init__
  File "/Users/spikesinc/gtk/inst/lib/python2.7/site-packages/xpra/client/tray_base.py", line 104, in set_icon_from_file
  File "/Users/spikesinc/gtk/inst/lib/python2.7/site-packages/xpra/client/gtk_base/statusicon_tray.py", line 117, in do_set_icon_from_file
  File "/Users/spikesinc/gtk/inst/lib/python2.7/site-packages/xpra/client/gtk_base/statusicon_tray.py", line 123, in set_icon_from_pixbuf
  File "/Users/spikesinc/gtk/inst/lib/python2.7/site-packages/xpra/client/gtk_base/statusicon_tray.py", line 91, in get_geometry
  File "/Users/spikesinc/gtk/inst/lib/python2.7/site-packages/xpra/client/gtk_base/statusicon_tray.py", line 46, in may_guess
  File "/Users/spikesinc/gtk/inst/lib/python2.7/site-packages/xpra/client/tray_base.py", line 148, in recalculate_geometry
  File "/Users/spikesinc/gtk/inst/lib/python2.7/site-packages/xpra/client/ui_client_base.py", line 554, in xpra_tray_geometry
AttributeError: 'NoneType' object has no attribute 'get_geometry'
Deallocating GtkQuartzStatusIcon
2014-09-12 15:22:20,224 event loop not started

It doesn't seem to affect functionality, but might be something worth looking at.

@totaam
Copy link
Collaborator Author

totaam commented Sep 13, 2014

2014-09-13 03:40:09: totaam changed status from new to assigned

@totaam
Copy link
Collaborator Author

totaam commented Sep 13, 2014

2014-09-13 03:40:09: totaam commented


Thanks.

The first stacktrace is because your builds have SHOW_ABOUT_XPRA set to false, this is fixed in r7595. This would have caused the forwarded tray to go missing.

The second one is very similar to #656, fixed in r7594. This would have caused the osx global menu to go missing.

Both should get backported.

@totaam
Copy link
Collaborator Author

totaam commented Sep 17, 2014

2014-09-17 05:01:30: totaam changed status from assigned to closed

@totaam
Copy link
Collaborator Author

totaam commented Sep 17, 2014

2014-09-17 05:01:30: totaam changed resolution from ** to fixed

@totaam
Copy link
Collaborator Author

totaam commented Sep 17, 2014

2014-09-17 05:01:30: totaam commented


Backports in 7655 and 7656. Closing.

@totaam totaam closed this as completed Sep 17, 2014
@totaam totaam added the v0.14.x label Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant