14.20 Xpra builds have no spinners

[totaam]

Issue migrated from trac ticket # 818

component: client | priority: minor | resolution: fixed

2015-02-26 20:54:54: maxmylyn created the issue

---

Tested builds from xpra.org/beta and xpra.org/dists:

• Windows 8634 14.20
• CentOS 6.4 20150219 build
• OSX 8600 14.19

Against a Fedora 20 20150219 14.20 build gotten from xpra.org/beta

And I'm not seeing any spinners upon network disconnect(unplugged ethernet cable). I do, however, see the print indicating that I should be seeing spinners.

[totaam]

2015-02-26 20:55:17: maxmylyn changed component from android to client

[totaam]

2015-02-27 06:13:31: totaam changed owner from antoine to maxmylyn

[totaam]

2015-02-27 06:13:31: totaam commented

---

This is fixed in 8708.
(the 0.15 branch removed the window-type normalization code which was causing this problem)

FYI: you can trigger the spinners just by running the client with:

XPRA_FAKE_BROKEN_CONNECTION=1 xpra attach ...

Easier than messing with network cables / connections!

If you find problems with the spinners, please always include opengl info and try turning that on or off. The paint window code is very different for each case.

[totaam]

2015-03-03 21:58:04: maxmylyn commented

---

Retested with an r8743 OSX, the 20150227 CentOS 6.4, and an r8743 Windows client against an r8743 Fedora 20 server:

• I see spinners on everything except OSX WITH OpenGL

[[BR]]

I should mention that I was seeing no spinners with and without OpenGL. I thought I included that in the original description but I must have missed it.

[totaam]

2015-03-05 04:42:40: totaam changed status from new to assigned

[totaam]

2015-03-05 04:42:40: totaam changed owner from maxmylyn to totaam

[totaam]

2015-03-05 04:42:40: totaam commented

---

(OK thanks, will test when I get a chance - my 10.5.x VM does not have opengl)

[totaam]

2015-03-21 18:06:25: antoine changed priority from major to minor

[totaam]

2015-03-21 18:06:25: antoine commented

---

Just tested on a 10.6 VM and the spinners work with the 0.15 beta builds, just not with the latest 0.14.21..

(lowering the priority as the focus is now on 0.15)

[totaam]

2015-04-27 17:37:12: antoine changed status from assigned to new

[totaam]

2015-04-27 17:37:12: antoine changed owner from totaam to maxmylyn

[totaam]

2015-04-27 17:37:12: antoine commented

---

9167 backports the painting of the spinners using opengl.
It makes sense to apply this because mixing opengl and cairo on the same window is not guaranteed to work and could even cause problems (and not just missing spinners - could be responsible for #646 for example).

Tested on Linux (Fedora), XP, and OSX 10.6 using: XPRA_FAKE_BROKEN_CONNECTION=1
I have uploaded beta 0.14.23 builds for osx and win32.

@maxmylyn: does this work for you? If so, please close the ticket.
It is worth briefly checking that this change does not interfere with opengl painting, be it video regions, normal paints, or even the window border option (ie: border=blue,5)

[totaam]

2015-04-28 19:45:12: maxmylyn commented

---

Tested OSX build:

• Spinners work as expected with and without opengl enabled

---

I'm also unable to locate the beta win32 build /beta.

[totaam]

2015-04-29 02:30:09: antoine changed status from new to closed

[totaam]

2015-04-29 02:30:09: antoine set resolution to fixed

[totaam]

2015-04-29 02:30:09: antoine commented

---

Closing.

Beta 0.14.23 for win32 were missing - sorry!

[totaam]

2015-05-06 10:50:07: antoine commented

---

Important fix for opengl spinners in r9271 (+backport for v0.14.x and v0.15.x in 9272)

Another potential fix for xpra 0.14.23 - Spinners not going away in r9265.

[totaam]

2015-05-10 12:58:56: antoine commented

---

I think it is quite possible that previous bugs were causing the crashes on win32 and osx, so r9291 tries to re-enable opengl by default on all platforms. We'll see how it goes.